-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Cycle 57 #1518
Comments
InfoRead BSQ amount from summary: 7075.47 ErrorsERROR: Total USD does not match the sum of line items:
|
I am sorry for the late request. This cycle has been hectic and extremely stressful. |
c325b0b95d47ceae66834645de428d438c9ad27bd59a1cea99941fab32b38306 |
Issuance by Team:
Total Issuance: 7075.47 BSQ (equivalent to: 15000.00 USD) |
Closed as accepted. |
Summary
7075.47
Contributions delivered
Nit
Please squash your commits and change the commit message to something like "Fix Code Comment Typos" or "Fix Typos in Code Comments". You can find our guide on how to write commit messages here: https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md#write-well-formed-commit-messages .
Nit
---------getdaostatus
is missing in the/bisq-cli --help
output.ACK
Tested:
bisq-cli --help
bisq-cli getdaostatus --help
bisq-cli getdaostatus
NACK
All BSQ Altcoin offers stay online, can be taken, and funds stay locked.
Test Scenario
Nit
I know that someone else wrote the original code but we should try to clean up existing code when working on it. We can avoid the redudant copying of the trade list by using
Collections.unmodifiableList(getObservableList())
.Apart from that I aggree with dutu. API consumers should be able to tell whether a trade failed.
---------utACK
utACK
DAO hashes match with my nodes too.
Nit
We can simplify the null and
isEmpty
handling withOptional<String>
s. MoreoverOptional
s enforce us to handle both cases and avoidNullPointerException
s.utACK
wiz Thank you very much for running everything over the last years!
utACK
Thank you!
Fixes #1764
Ref: #1798
Consumers can asynchronously subscribe to directory events with the Flow components.
Ref: #1798
Changes:
Ref: #1798
Presently, we parse Tor's log file to detect when the control port is ready. This is unstable and could break with any Tor update. A better approach is to use Tor's 'ControlPortWriteToFile' config option and parse the control port from that file.
Ref: #1798
Use the flow-component-based DirectoryWatcher to wait for the control port file and parse the control port file with the ControlPortFileParser afterward.
Ref: #1798
The text was updated successfully, but these errors were encountered: