Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data stores for v1.9.15 #7035

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

alejandrogarcia83
Copy link
Contributor

Light node in light mode and full node in dark mode
light_1
full_1
light_2
full_2
light_3
full_3
light_4
full_4

@alejandrogarcia83
Copy link
Contributor Author

@alvasw @HenrikJannsen @jmacxx Could anyone of you ACK this PR? Thanks!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also consider setting PROPOSAL_412_ACTIVATION_DATE which should be set to a few weeks after release date. See bisq-network/proposals#412 (comment)

As both traders need to have the exact same distribution for the delayed payout transaction we would need to roll that change out with a activation blockheight sufficiently far in the future so that we can be sure to release and enforce the updated version.

@@ -45,7 +45,7 @@ public class Version {
*/
public static final List<String> HISTORICAL_RESOURCE_FILE_VERSION_TAGS = Arrays.asList("1.4.0", "1.5.0", "1.5.2",
"1.5.5", "1.5.7", "1.6.0", "1.6.3", "1.6.5", "1.7.2", "1.7.4", "1.8.0", "1.8.1", "1.8.3", "1.9.0", "1.9.3",
"1.9.5", "1.9.6", "1.9.7", "1.9.10", "1.9.11", "1.9.13");
"1.9.5", "1.9.6", "1.9.7", "1.9.10", "1.9.11", "1.9.13", "1.9.15");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERSION = "1.9.15"
HISTORICAL...TAGS would have 1.9.14 (the prior version) appended.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct! 1.9.14 was a hotfix release without data store updates.

@HenrikJannsen
Copy link
Collaborator

I can confirm that my hashes on a light node are the same.

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

DAO hashes match with my nodes too.

@alejandrogarcia83 alejandrogarcia83 merged commit 117f282 into release/v1.9.15 Feb 25, 2024
6 checks passed
@alejandrogarcia83 alejandrogarcia83 deleted the update-data-stores-for-v1.9.15 branch February 25, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants