Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing grammatical errors in common/test/test_lint.py #1788

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fixing grammatical errors in common/test/test_lint.py #1788

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
184ac83
Fixed grammatical errors in comments
dnerever Jul 9, 2024
67c61bb
Correcting more grammatical errors within comments
dnerever Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions common/test/test_lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@


class MirrorMirrorOnTheWall(unittest.TestCase):
"""Check all py-files in the package (incl. test files) for lints and
"""Check all py-files in the package (incl. test files) for lints,
potential bugs and if they are compliant to the coding styles (e.g. PEP8).
"""

Expand All @@ -30,7 +30,7 @@ def _collect_py_files(self) -> Iterable[pathlib.Path]:

if not path.name.startswith('test'):
raise RuntimeError('Something went wrong. The test should run '
'inside the test folder but current folder '
'inside the test folder but the current folder '
f'is {path}.')

# Workaround
Expand All @@ -45,7 +45,7 @@ def test_with_pylint(self):

Some facts about PyLint
- It is one of the slowest available linters.
- It is able to catch lints none of the other linters
- It is able to catch lints other linters miss.
"""

# Pylint base command
Expand Down Expand Up @@ -103,9 +103,9 @@ def test_with_pylint(self):
'W4904', # deprecated-class
'W0614', # unused-wildcard-import

# Enable asap. This list is selection of existing (not all!)
# problems currently exiting in the BIT code base. Quit easy to fix
# because there count is low.
# Enable asap. This list is a selection of existing (not all!)
# problems currently existing in the BIT code base. Quite easy to fix
# because their count is low.
# 'R0801', # duplicate-code
# 'W0123', # eval-used
# 'W0237', # arguments-renamed
Expand All @@ -117,7 +117,7 @@ def test_with_pylint(self):

cmd.append('--enable=' + ','.join(err_codes))

# Add py files
# Add py-files
cmd.extend(self._collect_py_files())

r = subprocess.run(
Expand Down