Fixing grammatical errors in common/test/test_lint.py

[dnerever]

Fixes multiple grammatical errors within the comments on common/test/test_lint.py

[buhtz]

Hello Keith,
I am answering to your comment in #1755.

I am sure that the test would if pylint is not installed but to be sure please check if you get a valid output on your shell when executing pylint --version.

This was a good observation and it is always good to be suspicious. I cloned your repo and branch and just enabled W0612 rule in common/test/test_lint.pywithout modifying anything else. Then I get this error output.

************* Module tools
tools.py:2762:13: W0612: Unused variable 'procname' (unused-variable)
tools.py:2798:13: W0612: Unused variable 'procname' (unused-variable)
************* Module snapshotlog
snapshotlog.py:264:12: W0612: Unused variable 'e' (unused-variable)
************* Module sshtools
sshtools.py:571:16: W0612: Unused variable 'i' (unused-variable)
sshtools.py:838:16: W0612: Unused variable 'out' (unused-variable)
sshtools.py:1055:4: W0612: Unused variable 'out' (unused-variable)
sshtools.py:1176:4: W0612: Unused variable 'out' (unused-variable)
************* Module snapshots
snapshots.py:2931:41: W0612: Unused variable 'f' (unused-variable)
************* Module schedule
schedule.py:167:12: W0612: Unused variable 'grep' (unused-variable)
************* Module encfstools
encfstools.py:525:14: W0612: Unused variable 'port' (unused-variable)
encfstools.py:525:32: W0612: Unused variable 'cipher' (unused-variable)
************* Module config
config.py:1606:16: W0612: Unused variable 'i' (unused-variable)
************* Module test.test_takeSnapshot
test/test_takeSnapshot.py:268:8: W0612: Unused variable 'hash_id' (unused-variable)
************* Module test.test_applicationinstance
test/test_applicationinstance.py:213:42: W0612: Unused variable 'f' (unused-variable)
************* Module test.test_snapshots
test/test_snapshots.py:603:42: W0612: Unused variable 'f' (unused-variable)
************* Module test.test_sid
test/test_sid.py:313:37: W0612: Unused variable 'f' (unused-variable)
test/test_sid.py:326:37: W0612: Unused variable 'f' (unused-variable)
test/test_sid.py:549:12: W0612: Unused variable 'item' (unused-variable)
************* Module test.test_plugin_usercallback
test/test_plugin_usercallback.py:182:12: W0612: Unused variable 'to_eval' (unused-variable)

It might be that you execute pytest in the wrong folder. You should navigate into common. Maybe it helps if you post your full console output and the commands you try to execute.

[dnerever]

Thanks for the answer Christian. I tried it one more time following your steps and it worked! I'm still not sure what I was doing before but thanks for your guidance. I went ahead and created a new branch and PR #1790 for fixing the linting errors and left this PR for just the grammatical fixes. Thanks again for the help.