Worked on fixing issue W0612 (unused-variable) in "common"

[dnerever]

Fixed the occurrence of unused variables through multiple files within /common

Related to #1755

[buhtz]

Hello Keith,
Thank you for that PR. You see it can get complicated. I added some comments. Let me know how you want to proceed.

Because of its complexity and possible impact I schedule that PR until the upcoming release (see milestone).

[dnerever]

Hey Christian,
Can you direct me to where you added your comments.

I do see how it can get complicated so delaying it makes sense. Any suggestions for ensuring my future PRs avoid introducing complexity? I'm going now to take a look at the other opens issues in the repo.

Thanks again for all the help!

[buhtz]

You are not the one making it complicated. The old and smelly Back In Time code does. I just tried to pointing out that even simple modifications can become complicated in old code base like Back In Time has.

About the comments. I added 4 comments directly to the diff-like output. This means a comment is connected directly to a line in the code. I marked them with yellow circles in this screenshot. Just scroll up.

[buhtz]

To prevent you from extra work and wasting time, I just want to mention that someone else will work on the same rule but in "qt" folder.

#1755 (comment)

EDIT: By the way I realized that you did not activate the W0612 rule in common/test/test_lint.py in this PR. Is there are reason? If all W0612 errors in "common" are fixed you can activate it.

[buhtz]

Please see my last comment.

[buhtz]

I see why you didn't enable W0612 by default. There are to many errors.