Fix unreasonable default size of the main window without loaded wallets #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the layout of a WalletFrame widget correct even without loaded wallets.
This was referenced Oct 25, 2020
|
Looks like it should take into account |
I've tried your suggestion and got: |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 27, 2020
… window without loaded wallets 7b2e42e qt: Add WalletFrame::sizeHint (Hennadii Stepanov) Pull request description: This PR fixes a bug in master (d67883d) and in 0.20.1 that could be easily reproduced with ``` $ src/qt/bitcoin-qt -regtest -resetguisettings -nowallet ```   **With this PR:**   --- Fix #104 Fix #113 This PR is an alternative to #107 without [hard-coding a size in pixels](bitcoin-core/gui#107 (comment)). ACKs for top commit: jonasschnelli: Tested ACK 7b2e42e - I can confirm this fixes #104 (Ubuntu 20.04 - HiDPI 200%). Tree-SHA512: eb0692dbeb3befdeecca0e41534c9783eab6637c14cc4f170ee42619235884f9354f8d22a10c20c08cc89dc5340a60b7dfa2523c12e64b3386b3fd2c6d5f934e
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Dec 3, 2020
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Mar 23, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 15, 2021
Summary: This change makes the layout of a WalletFrame widget correct even without loaded wallets. Previously, the window was very small, and as a result the progress dialog overlay was invisible. This is a backport of [[bitcoin-core/gui#116 | core-gui#116]] Test Plan: `src/qt/bitcoin-qt -regtest -resetguisettings -nowallet` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10680
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in master (d67883d) and in 0.20.1 that could be easily reproduced with
With this PR:
Fix #104
Fix #113
This PR is an alternative to #107 without hard-coding a size in pixels.