Avoid generating an empty list as the left operand to NOT IN #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres treats 'x in ()' and 'x not in ()' as syntax errors. Instead translate: x in () ⇒ FALSE x not in () ⇒ TRUE Older versions of esqueleto did this, but apparently the latter got lost.
belevy
approved these changes
Jul 8, 2021
|
@belevy let me know if I bumped the version/updated the changelog correctly |
|
Yah, this is fixing a bug that was introduced. The behavior isnt new. I think the minor bump is fine. |
|
Thank you for the fix :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres treats
x in ()andx not in ()as syntax errors. Instead translate:Older versions of esqueleto did both of these, but apparently the latter got lost in the most recent version. See issue #272.
Before submitting your PR, check that you've:
I'm not sure what the version number should be, looks like esqueleto uses PVP?I bumped the smallest component to3.5.2.1since this is a bugfix@sincedeclarations to the Haddock. N/Astylish-haskelland otherwise adhered to the style guide.After submitting your PR: