Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid generating an empty list as the left operand to NOT IN #273

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Avoid generating an empty list as the left operand to NOT IN #273

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cebdf28
Avoid generating an empty list as the left operand to NOT IN
cdparks Jul 8, 2021
e9a1261
Bump version and update changelog
cdparks Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Database/Esqueleto/Internal/Internal.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,7 +939,11 @@ notIn :: PersistField typ => SqlExpr (Value typ) -> SqlExpr (ValueList typ) -> S
ERaw noMeta $ \_ info ->
let (b1, vals1) = v Parens info
(b2, vals2) = list Parens info
in (b1 <> " NOT IN " <> b2, vals1 <> vals2)
in
if b2 == "()" then
("TRUE", [])
else
(b1 <> " NOT IN " <> b2, vals1 <> vals2)

-- | @EXISTS@ operator. For example:
--
Expand Down
13 changes: 13 additions & 0 deletions test/Common/Test.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1431,6 +1431,19 @@ testListOfValues = describe "lists of values" $ do
return p
asserting $ ret `shouldBe` [ Entity p2k p2 ]

itDb "NOT IN works for valList (null list)" $ do
p1k <- insert p1
p2k <- insert p2
p3k <- insert p3
ret <- select $
from $ \p -> do
where_ (p ^. PersonName `notIn` valList [])
return p
asserting $ ret `shouldMatchList` [ Entity p1k p1
, Entity p2k p2
, Entity p3k p3
]

itDb "EXISTS works for subList_select" $ do
p1k <- insert p1
_p2k <- insert p2
Expand Down