Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown #15

Closed
calind opened this issue Nov 20, 2017 · 3 comments · Fixed by #576
Closed

Graceful shutdown #15

calind opened this issue Nov 20, 2017 · 3 comments · Fixed by #576

Comments

@calind
Copy link
Member

calind commented Nov 20, 2017 •
edited
Loading

https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/

When a pod is shut down gracefully it should:

  1. set to maintenance in orchestrator
  2. if it's master, then the operator should do a graceful failover if there are other slaves
@calind calind added this to the Beta milestone Nov 20, 2017
@calind calind changed the title Create backup on master shutdown Gracefull shutdown Mar 22, 2018
@calind calind modified the milestones: Beta, Production level Mar 22, 2018
@calind calind changed the title Gracefull shutdown Graceful shutdown Mar 22, 2018
@calind calind modified the milestones: Production level, 0.2.x Jul 17, 2018
@calind calind mentioned this issue Jan 14, 2019
Open
@calind calind modified the milestones: 0.2.x, 0.2.4, 0.2.5 Jan 28, 2019
@calind
Copy link
Member Author

calind commented Feb 1, 2019

We need a resolution on kubernetes/kubernetes#73584 before proceeding.

@calind calind modified the milestones: 0.2.5, 0.2.x Feb 1, 2019
@calind calind mentioned this issue Feb 1, 2019
Closed
@afirth
Copy link

afirth commented Mar 10, 2019

This would be super helpful, but I'm pretty confident that pod finalizers won't work (the container will die before finalizers are executed). I think the container needs to trap SIGTERM on pid 1, or use prestop hooks. Would you be able to explain the issue you faced with prestop? Would be great to see this feature in, might solve the majority of #107 causes too.

@AMecea AMecea modified the milestones: 0.2.x, 0.3.x Mar 11, 2019
@AMecea AMecea modified the milestones: 0.3.x, 0.4.x Apr 2, 2019
@cndoit18 cndoit18 linked a pull request Sep 17, 2021 that will close this issue
Parameterize compress/decompress commands #624
Merged
1 task
@cndoit18 cndoit18 removed a link to a pull request Sep 17, 2021
Parameterize compress/decompress commands #624
Merged
1 task
@cndoit18 cndoit18 mentioned this issue Sep 17, 2021
Merged
@cndoit18
Copy link
Collaborator

I think this is done
cc @calind

@calind calind removed this from the 0.4.x milestone Oct 11, 2021
@calind calind closed this as completed Oct 11, 2021
chapsuk pushed a commit to chapsuk/mysql-operator that referenced this issue Oct 16, 2023
@enisoc @PrismaPhonic
Add git hook to prompt for DCO signoff. (bitpoke#15)
9fef457 
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix pod labels diff and add preStop for mysql container jianhaiqing/mysql-operator
4 participants
@calind @afirth @AMecea @cndoit18