-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize compress/decompress commands #624
Parameterize compress/decompress commands #624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should include COMPRESS_COMMAND
env on the sidecar
container because new replicas (scaling-up) are added using the same mechanism as backups.
Let's check if only one of those field is specified and warn the user if so (logging the message should be enough).
71f13a6
to
0d59685
Compare
I might be missing something, but it looks like the
Done: 0d59685 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just one thing, please squash commits to keep a cleaner history. 😄
Thank you for your contribution!
b8f4189
to
0c89334
Compare
Of course! Done. |
An improved version of #517.
Adds
backupCompressCommand
andbackupDecompressCommand
options that allow using any compressor/decompressor for backups. These options support arbitrary command line args as well.Falls back to using
gzip
if the options are not provided.