Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unhandled item types while importing ProtonPass #10654

Closed
1 task done
rsb-23 opened this issue Aug 21, 2024 · 3 comments · Fixed by #10967
Closed
1 task done

Skip unhandled item types while importing ProtonPass #10654

rsb-23 opened this issue Aug 21, 2024 · 3 comments · Fixed by #10967
Labels
browser Browser Extension bug cli CLI Application desktop Desktop Application good first issue web

Comments

@rsb-23
Copy link

rsb-23 commented Aug 21, 2024

Steps To Reproduce

  1. Go to 'Import from Proton(zip/json)'
  2. Upload proton.json file with alias items.
  3. Click on 'Import Data' button.

Expected Result

Unhandled item types shouldn't be added as a blank entry to the vault.
Skip alias and identity items if it is not handled, and show skipped items count at last.

Actual Result

Getting item entry with just item name and without any username or email address.
This is of no use and also user mistakes it for successful import.

Screenshots or Videos

No response

Additional Context

Fix Suggestions:

  1. Add default clause to this switch case
default:
   continue
  1. Also handle identity item type.

Operating System

Windows

Operating System Version

No response

Web Browser

Brave

Browser Version

No response

Build Version

na

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@daniellbw
Copy link

Hi there,

This issue has been escalated for further investigation. If you have more information that can help us, please add it below.

Thanks!

@rsb-23
Copy link
Author

rsb-23 commented Aug 21, 2024

Has #10471 changes been deployed to web and other clients?
Currently, some usernames are blank after import.

I don't have anymore details as of now, let me know if I can help with anything.

Additionally :
Incase if the team plans to add identity, here is the type

export type ProtonPassIdentityContent = {
fullName:string,email:string,phoneNumber:string,firstName:string,middleName:string,lastName:string,birthdate:string,gender:string,extraPersonalDetails:string[],
organization:string,streetAddress:string,zipOrPostalCode:string,city:string,stateOrProvince:string,countryOrRegion:string,floor:string,county:string,extraAddressDetails:string[],
socialSecurityNumber:string,passportNumber:string,licenseNumber:string,website:string,xHandle:string,secondPhoneNumber:string,linkedin:string,reddit:string,facebook:string,yahoo:string,instagram:string,extraContactDetails:string[],
company:string,jobTitle:string,personalWebsite:string,workPhoneNumber:string,workEmail:string,extraWorkDetails:string[],
extraSections:string[]
};

@djsmith85 djsmith85 added browser Browser Extension desktop Desktop Application cli CLI Application good first issue labels Aug 22, 2024
@djsmith85
Copy link
Contributor

djsmith85 commented Aug 22, 2024

Hi @rsb-23, and thank you for your report.

The changes #10471 you mention have not been released yet. They will be included in the next release.

I've added this ticket to my team's backlog, but I'm also marking this as a good first issue, in case anyone would like to take a stab at skipping unmapped/unsupported items and/or mapping aliases and identities.

Kind regards,
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug cli CLI Application desktop Desktop Application good first issue web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants