Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11882] [PR to build artifacts] Handled identity item and unsupported items during ProtonPass import. #11009

Closed
wants to merge 5 commits into from

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Sep 12, 2024

🎟️ Tracking

#10654

📔 Objective

PR to build artifacts for #10967

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Tyrrrz Tyrrrz requested a review from a team as a code owner September 12, 2024 18:14
@Tyrrrz Tyrrrz added the hold do not merge, do not approve yet label Sep 12, 2024
Copy link
Contributor

github-actions bot commented Sep 12, 2024

Logo
Checkmarx One – Scan Summary & Detailsf5fbbfe7-9a72-4a1a-bea4-009b4cdf3f84

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.17%. Comparing base (89751f4) to head (16d2f3d).
Report is 60 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/importers/protonpass/protonpass-json-importer.ts 97.91% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11009      +/-   ##
==========================================
+ Coverage   35.14%   35.17%   +0.03%     
==========================================
  Files        2690     2691       +1     
  Lines       83666    83744      +78     
  Branches    15887    15909      +22     
==========================================
+ Hits        29403    29459      +56     
- Misses      53297    53318      +21     
- Partials      966      967       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsmith85 djsmith85 marked this pull request as draft September 16, 2024 10:47
@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Sep 18, 2024

Closing as the original PR has been merged.

@Tyrrrz Tyrrrz closed this Sep 18, 2024
@Tyrrrz Tyrrrz removed the hold do not merge, do not approve yet label Sep 18, 2024
@Tyrrrz Tyrrrz deleted the community/pm-11882/protonpass-identity-import branch September 18, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants