Handshake request #3277
Merged
Handshake request #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
differsthecat
changed the base branch from
ddg-integration
to
native-messaging-handler
kspearrin
approved these changes
Aug 11, 2022
differsthecat
added a commit
that referenced
this pull request
Sep 23, 2022
* [SG-523] Base test runner app for native messages (#3269) * Base test runner app for native messages * Remove default test script * Add case for canceled status * Modify to allow usage of libs crypto services and functions * Small adjustments * Handshake request (#3277) * Handshake request * Fix capitalization * Update info text * lock node-ipc to 9.2.1 * [SG-569] Native Messaging settings bug (#3285) * Fix bug where updating setting wasn't starting the native messaging listener * Update test runner error message * [SG-532] Implement Status command in Native Messaging Service (#3310) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Add active field to status response * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * Remove in progress file (merge error) * Move models to their own folder and add index.ts * Remove file that got un-deleted * Remove file that will be added in separate command * Fix imports that got borked * [SG-533] Implement bw-credential-retrieval (#3334) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Implement bw-credential-retrieval * Add active field to status response * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * Add error handling for passing a bad public key to handshake * [SG-534] and [SG-535] Implement Credential Create and Update commands (#3342) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Implement bw-credential-retrieval * Add active field to status response * Add bw-credential-create * Better response handling in test runner * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * bw-cipher-create move type into its own file * Use LogUtils for all logging * Implement bw-credential-update * Give naming conventions for types * Rename file correctly * Update handleEncyptedMessage with EncString changes * [SG-626] Fix Desktop app not showing updated credentials from native messages (#3380) * Add MessagingService to send messages on login create and update * Add `not-active-user` error to create and update and other refactors * [SG-536] Implement bw-generate-password (#3370) * implement bw-generate-password * Fix merge conflict resolution errors * Update apps/desktop/native-messaging-test-runner/src/bw-generate-password.ts Co-authored-by: Addison Beck <addisonbeck1@gmail.com> * Logging improvements * Add NativeMessagingVersion enum * Add version check in NativeMessagingHandler Co-authored-by: Addison Beck <addisonbeck1@gmail.com> * Refactor account status checks and check for locked state in generate command (#3461) * Add feawture flag to show/hide ddg setting (#3506) * [SG-649] Add confirmation dialog and tweak shared key retrieval (#3451) * Add confirmation dialog when completing handshake * Copy updates for dialog * HandshakeResponse type fixes * Add longer timeout for handshake command * [SG-663] RefactorNativeMessagingHandlerService and strengthen typing (#3551) * NativeMessageHandlerService refactor and additional types * Return empty array if no uri to retrieve command * Move commands from test runner into a separate folder * Fix bug where confirmation dialog messes with styling * Enable DDG feature * Fix generated password not saving to history * Take credentialId as parameter to update * Add applicationName to handshake payload * Add warning text to confirmation modal Co-authored-by: Addison Beck <addisonbeck1@gmail.com>
shane-melton
pushed a commit
that referenced
this pull request
Sep 27, 2022
* [SG-523] Base test runner app for native messages (#3269) * Base test runner app for native messages * Remove default test script * Add case for canceled status * Modify to allow usage of libs crypto services and functions * Small adjustments * Handshake request (#3277) * Handshake request * Fix capitalization * Update info text * lock node-ipc to 9.2.1 * [SG-569] Native Messaging settings bug (#3285) * Fix bug where updating setting wasn't starting the native messaging listener * Update test runner error message * [SG-532] Implement Status command in Native Messaging Service (#3310) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Add active field to status response * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * Remove in progress file (merge error) * Move models to their own folder and add index.ts * Remove file that got un-deleted * Remove file that will be added in separate command * Fix imports that got borked * [SG-533] Implement bw-credential-retrieval (#3334) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Implement bw-credential-retrieval * Add active field to status response * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * Add error handling for passing a bad public key to handshake * [SG-534] and [SG-535] Implement Credential Create and Update commands (#3342) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Implement bw-credential-retrieval * Add active field to status response * Add bw-credential-create * Better response handling in test runner * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * bw-cipher-create move type into its own file * Use LogUtils for all logging * Implement bw-credential-update * Give naming conventions for types * Rename file correctly * Update handleEncyptedMessage with EncString changes * [SG-626] Fix Desktop app not showing updated credentials from native messages (#3380) * Add MessagingService to send messages on login create and update * Add `not-active-user` error to create and update and other refactors * [SG-536] Implement bw-generate-password (#3370) * implement bw-generate-password * Fix merge conflict resolution errors * Update apps/desktop/native-messaging-test-runner/src/bw-generate-password.ts Co-authored-by: Addison Beck <addisonbeck1@gmail.com> * Logging improvements * Add NativeMessagingVersion enum * Add version check in NativeMessagingHandler Co-authored-by: Addison Beck <addisonbeck1@gmail.com> * Refactor account status checks and check for locked state in generate command (#3461) * Add feawture flag to show/hide ddg setting (#3506) * [SG-649] Add confirmation dialog and tweak shared key retrieval (#3451) * Add confirmation dialog when completing handshake * Copy updates for dialog * HandshakeResponse type fixes * Add longer timeout for handshake command * [SG-663] RefactorNativeMessagingHandlerService and strengthen typing (#3551) * NativeMessageHandlerService refactor and additional types * Return empty array if no uri to retrieve command * Move commands from test runner into a separate folder * Fix bug where confirmation dialog messes with styling * Enable DDG feature * Fix generated password not saving to history * Take credentialId as parameter to update * Add applicationName to handshake payload * Add warning text to confirmation modal Co-authored-by: Addison Beck <addisonbeck1@gmail.com>
kspearrin
added a commit
that referenced
this pull request
Oct 20, 2022
* Update steps in web workflows (#3463) * Fix file casing (#3468) * [SM-204] Add the `curly` eslint rule (#3464) * Autosync the updated translations (#3471) Co-authored-by: github-actions <> * [PS-1387] Desktop: Remove "delete account" from settings (#3406) * Autosync the updated translations (#3473) Co-authored-by: github-actions <> * Autosync the updated translations (#3472) Co-authored-by: github-actions <> * Change name of Windows Store to Microsoft Store (#3476) * Remove admin url from config object (#3479) * [SG-656] Fix Trial Initiation Captcha Issue (#3481) * [refactor] Isolate form validation logic * [refactor] Relocate a few input scrubbing lines * [refactor] Isolate RegisterRequest object construction logic * [refactor] Isolate account registration logic * [refactor] Isolate login logic * [fix] Check for captchas during login from trial initiation * [fix] Avoid a duplicated toast if the account was already created * [fix] Add a fail state to registerAccount for failing validation (#3482) * Bump Desktop version to 2022.9.0 (#3492) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [SM-224] Change the simple dialog width (#3475) * Bump Desktop version to 2022.9.1 (#3495) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Bump Browser version to 2022.9.0 (#3494) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Bump CLI version to 2022.9.0 (#3493) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update LICENSE_BITWARDEN.txt (#3505) * [CL-44] [EC-525] Update button disabled state (#3282) * [CL-44] Update button disabled state * [CL-44] [EC-525] Fixed opacity issue with background/border * [SG-659] Classic 2019 plans no longer generating TOTP codes for Free users (#3509) * [SG-659] Fixed TOTP code visibility for users with classic plans. * [SG-659] Refactored condition. * [SG-659] Ran prettier * [SG-659] Simplified expression. * Make all item fields (except linked fields) draggable (#3321) Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com> * [PS-1474] Bump rust dependencies (#3515) * Bump rust dependencies * Selecitvely upgrade only napi * Upgrade only parking_lot_core * Autosync the updated translations (#3519) Co-authored-by: github-actions <> * Autosync the updated translations (#3518) Co-authored-by: github-actions <> * Autosync the updated translations (#3517) Co-authored-by: github-actions <> * Bump Browser version to 2022.9.1 (#3527) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update CSP rule for Angular CDK (#3529) * [EC-457] Component library icon buttons (#3372) * [EC-457] feat: initial version of icon button * [EC-457] feat: modify template and start adding inputs * [EC-457] feat: implement all styles * [EC-457] chore: cleanup * [EC-457] feat: fix hover styles after discussions * [EC-457] feat: add focus ring workaround * [EC-457] chore: refactor stories a bit * [EC-457] fix: button style attr name reserved word collision * [EC-356] feat: match padding with figma * [EC-457] feat: use icon button in banner * [EC-457] chore: cleanup css classes * [EC-457] feat: improve aria * [EC-457] feat: use icon button in dialog * [EC-457] fix: make focus and hover styles independent * [EC-457] fix: remove primary 500 border * [EC-457] chore: cleanup * [EC-457] chore: move css class to common list * [EC-457] fix: use focus-visible * [EC-457] chore: expand on workaround fix * [EC-457] fix: default sizing * [EC-457] fix: align trash icon right * [EC-457] fix: add missing aria labels * [EC-457] fix: add i18n service to banner tests * [EC-457] chore: rename size `default` to `button` * [EC-457] feat: double padding * [EC-457] feat: simplify sizes - update default * [EC-457] fix: revert selector fix - gonna create separate pr * [EC-457] chore: remove superfluous dependencies * [EC-457] fix: remove non-working onClose handler Removing this storybook action because we already test it as part of the dialog service stories. It requries mocking the dialogRef to capture the close function which makes this story more complex but adds very little value as we already test it elsewhere. * [PS-1111] Added prefix "Vault:" for accessibility on vault selector items (#3188) * PS-1111 Added prefix "Vault:" for accessibility to vault selector items * improved html readability * PS-1111 Added more screen reader accessibility data to the Vault selector on Desktop and Web clients * PS-1111 removed duplicated aria-label * PS-1111 Removed unnecessary aria-label attribute * PS-1111 Changed browser vault item accessibility title from span to button * Updated description based on what we show on other stores (#3478) * [PS-1447] Fix issues with CLI stores (npm/choco/snapcraft) (#3477) * Fix repository url to point to the clients repo * Fix missing description in snapcraft.yml * Nuspec: Fix links to point to clients repo * Nuspec: Use the correct brand icon(same as desktop) * Nuspec:Update description based on other stores (browser) * [PS-1469] Ensure the window is focused when prompting for biometrics (#3534) * Modified Fastmail CSP to match QA and Production proxies. * Bumped web version to 2022.9.1 (#3539) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [SG-397] Configure jest for Desktop and add simple tests (#3467) * Configure jest for Desktop and add simple tests * Remove Jest from tsconfig types * [SG-590] Missing error messages (#3514) * added removed locale keys on clients * resolved comments * [SG-656] Use a captcha bypass during registration (#3531) * Use a captcha bypass during registration The trial initiation flow has a registration step that automatically does a login in the background. This has Captcha problems, namely that it can spawn two captchas in a row - one during registration and one during login. This is not ideal UX, so we've added a bypass token that returns from the registration endpoint that can be used to skip the next captcha. * [review] Introduce ICaptcheProtectedResponse * Autosync the updated translations (#3545) Co-authored-by: github-actions <> * Autosync the updated translations (#3546) Co-authored-by: github-actions <> * Autosync the updated translations (#3547) Co-authored-by: github-actions <> * [CL-54] Add support for button block without argument + submit button (#3498) * Automatically build native rust for desktop in dev (#3510) * [Ps 1319] When the name of an entry is too long, the Icon indicating it is shared is not shown (#3500) * fixing the bug ps-1319 by using ellipsis pipe which deafultg 25 character length * pass 20 as the limit length instead default 25 Co-authored-by: dynwee <onwudiweokeke@gmail.com> * [DEVOPS-996] - Refactor Web build workflow (#3558) * Add type=button to dialog close (#3565) * [SM-223] Web: change `<h2>` modal title to `<h1>`, tweak styles to keep same look (#3328) Co-authored-by: Hinton <hinton@users.noreply.github.com> * patch web build workflows with docker builds * Don't try and parse a json response if one is not received (#3574) * Corrected help command string (#3560) * Correct bw send get -h internal CLI documentation (#3576) * Autosync the updated translations (#3583) Co-authored-by: github-actions <> * Autosync the updated translations (#3582) Co-authored-by: github-actions <> * Autosync the updated translations (#3581) Co-authored-by: github-actions <> * Bumped web version to 2022.9.2 (#3586) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Ps 1291/apply to from json pattern to state (#3425) * Clean up dangling behaviorSubject * Handle null in utils * fix null check * Await promises, even in async functions * Add to/fromJSON methods to State and Accounts This is needed since all storage in manifest v3 is key-value-pair-based and session storage of most data is actually serialized into an encrypted string. * Simplify AccountKeys json parsing * Fix account key (de)serialization * Remove unused DecodedToken state * Correct filename typo * Simplify keys `toJSON` tests * Explain AccountKeys `toJSON` return type * Remove unnecessary `any`s * Remove unique ArrayBuffer serialization * Initialize items in MemoryStorageService * Revert "Fix account key (de)serialization" This reverts commit b1dffb5, which was breaking serializations * Move fromJSON to owning object * Add DeepJsonify type * Use Records for storage * Add new Account Settings to serialized data * Fix failing serialization tests * Extract complex type conversion to helper methods * Remove unnecessary decorator * Return null from json deserializers * Remove unnecessary decorators * Remove obsolete test * Use type-fest `Jsonify` formatting rules for external library * Update jsonify comment Co-authored-by: @eliykat * Remove erroneous comment * Fix unintended deep-jsonify changes * Fix prettierignore * Fix formatting of deep-jsonify.ts Co-authored-by: Thomas Rittson <trittson@bitwarden.com> Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> * fix secret pull (#3591) * [DEVOPS-933] - Migrate QA Web to cloudflare pages (#3569) * Add stub for ephemeral env web build workflow (#3593) * Autosync the updated translations (#3597) Co-authored-by: github-actions <> * Autosync the updated translations (#3598) Co-authored-by: github-actions <> * [SG-520] Native messaging handler (#3566) * [SG-523] Base test runner app for native messages (#3269) * Base test runner app for native messages * Remove default test script * Add case for canceled status * Modify to allow usage of libs crypto services and functions * Small adjustments * Handshake request (#3277) * Handshake request * Fix capitalization * Update info text * lock node-ipc to 9.2.1 * [SG-569] Native Messaging settings bug (#3285) * Fix bug where updating setting wasn't starting the native messaging listener * Update test runner error message * [SG-532] Implement Status command in Native Messaging Service (#3310) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Add active field to status response * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * Remove in progress file (merge error) * Move models to their own folder and add index.ts * Remove file that got un-deleted * Remove file that will be added in separate command * Fix imports that got borked * [SG-533] Implement bw-credential-retrieval (#3334) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Implement bw-credential-retrieval * Add active field to status response * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * Add error handling for passing a bad public key to handshake * [SG-534] and [SG-535] Implement Credential Create and Update commands (#3342) * Status command start * Refactor ipc test service and add status command * fixed linter errors * Move types into a model file * Cleanup and comments * Fix auth status condition * Remove .vscode settings file. Fix this in a separate work item * Implement bw-credential-retrieval * Add active field to status response * Add bw-credential-create * Better response handling in test runner * Extract native messaging types into their own files * Remove experimental decorators * Turn off no console lint rule for the test runner * Casing fix * Models import casing fixes * bw-cipher-create move type into its own file * Use LogUtils for all logging * Implement bw-credential-update * Give naming conventions for types * Rename file correctly * Update handleEncyptedMessage with EncString changes * [SG-626] Fix Desktop app not showing updated credentials from native messages (#3380) * Add MessagingService to send messages on login create and update * Add `not-active-user` error to create and update and other refactors * [SG-536] Implement bw-generate-password (#3370) * implement bw-generate-password * Fix merge conflict resolution errors * Update apps/desktop/native-messaging-test-runner/src/bw-generate-password.ts Co-authored-by: Addison Beck <addisonbeck1@gmail.com> * Logging improvements * Add NativeMessagingVersion enum * Add version check in NativeMessagingHandler Co-authored-by: Addison Beck <addisonbeck1@gmail.com> * Refactor account status checks and check for locked state in generate command (#3461) * Add feawture flag to show/hide ddg setting (#3506) * [SG-649] Add confirmation dialog and tweak shared key retrieval (#3451) * Add confirmation dialog when completing handshake * Copy updates for dialog * HandshakeResponse type fixes * Add longer timeout for handshake command * [SG-663] RefactorNativeMessagingHandlerService and strengthen typing (#3551) * NativeMessageHandlerService refactor and additional types * Return empty array if no uri to retrieve command * Move commands from test runner into a separate folder * Fix bug where confirmation dialog messes with styling * Enable DDG feature * Fix generated password not saving to history * Take credentialId as parameter to update * Add applicationName to handshake payload * Add warning text to confirmation modal Co-authored-by: Addison Beck <addisonbeck1@gmail.com> * Fix CLI Snap permissions (#3596) * Update permission title to allow for translations (#3607) * Fix packaging on Build Web workflow (#3613) * Add Selfhost job to Build Web check for failures job (#3614) * Autosync the updated translations (#3617) Co-authored-by: github-actions <> * Autosync the updated translations (#3619) Co-authored-by: github-actions <> * Autosync the updated translations (#3618) Co-authored-by: github-actions <> * [EC 456] Component Library Content Switching Tabs (#3452) * [EC-456] Rename bitTabItem -> bitTab * [EC-456] Use templateRefs or text for tab label content * [EC-456] Add bit-tab-nav-bar component * [EC-456] Finish content tab switching and nav tabs * [EC-456] Undo accidental eslintrc.json change * [EC-456] Fix directive/component selector naming convention * [EC-456] Cleanup unnecessary InjectionTokens and simplify template label property * [EC-456] Cleanup one more unnecessary InjectionToken * [EC-456] Cleanup tab styles to better match Figma. Add internal tab header component for styling header background according to Figma. * [EC-456] Add sub-folders for nav, content, and shared tab components/directives * [EC-456] Code/style cleanup * [EC-456] Remove underscore from protected members * [EC-456] Cleanup tab stories and forgotten any type. * [EC-456] Fix dark theme story tab content text color * [EC-456] Add missing padding to tab header * [EC-456] Add tab content padding to align with tab headers * [EC-456] Move bottom tab border to header to span entire content area * [EC-456] Force text-main tab label color * [EC-456] Undo text-main change * [SG-168] Passwordless login web MVP (#3424) * passwordless login page redesign * passwordless login page redesign * restyled login form to use tailwind * restyled login form to use tailwind * moved texts on login device template to locales * made reactive form changes for clients * added request model * made more changes * added implmentation to auth request api * fixed refrencing issue * renamed model property * Added resend notification functionality * Added new file * login with device first draft * login with device first draft * login with device first draft * login with device first draft * connection to anonymous hub * connection to anonymous hub * refactored confirm login response * removed comment * cleaned up login * changed uptyped form builder * changed uptyped form builder * [SG-168] Update login strategy with passwordless login credentials. * [SG-168] Removed logs. Changed inputs for passwordless logic strategy. Removed tokenRequestPasswordless it is using the same as password. * code cleanup * code cleanup * removed login with device from self hosted * fixed PR comments * added module for login * fixed post request bug * added feature flag * added feature flag * added feature flag Co-authored-by: André Bispo <abispo@bitwarden.com> * Prevent banned imports into libs/common (#3599) Also fix typescript-eslint/parser config and fix linting errors * fix: icon button style incompats (#3611) * [EC-556] refactor cl button (#3537) * [EC-556] feat: convert button into component * [EC-556] feat: implement loading state * [EC-556] feat: remove loading from submit button * [EC-556] fix: add missing import * [EC-556] fix: disabling button using regular attribute * [EC-556] fix: missing loading input in story templates * [EC-556] feat: remove and replace submit button * Fix packaging on Build Web workflow (#3613) (cherry picked from commit 67c447d) * [EC-556] fix: replaced buttons should be primary Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com> * Fix storybook (#3625) * Fix last seen & spacing issue (#3567) * Fix last seen & spacing issue * Address PR comments, moving try catch to config service * Added CSP rule for DDG email fowarder API (#3630) Co-authored-by: Todd Martin <> * corrected typos (#3633) * [PS-1092] Organization Service Observables (#3462) * Update imports * Implement observables in a few places * Add tests * Get all clients working * Use _destroy * Address PR feedback * Address PR feedback * Address feedback * Fix web qa deployment (#3632) * Comment unzip downloaded artifact * Replace gihub ref with master * Add debug commands * Change CP command * Add another debug code * Fix * Another fix * Remove debug steps * Remove master const branch after testing * Make content padding optional on Dialog components to support tab group content (#3634) * updated submit button to use the block directive and add loader (#3644) * Minor workspace tweaks (#3636) * Add storybook-static to .gitignore * Set auto-imports to be project relative * Add Types for Opera API (#3631) * Add global types * Update to self * Remove main.backgroun changes * Remove one more change * Fix alignment for long filter names (#3635) * Add EE specific web container image (#3604) * Add build command for ee * Add config for ee * Add build workflow for ee * Change build pipeline for web ee * Fix name of workflow in trigger * Build ee image in web build workflow * Fix name on matrix * FIx name of the artifact * Comment out zip extract * Add zip extract * All listing dir before unzip * Add pwd * Comment out unzipping * Fix * Add matrix instead of two stages * Remove build web ee workflow * Fix name * [SM-254] Rename web vault imports from src to web-vault (#3626) * [SM-247] Fix csp rules not working for local dev (#3588) * [SM-255] Forbid absolute imports in libs (#3624) * Ensure avatar component is stable (#3640) * Rename anonymousHub route to anonymous-hub (#3650) * Autosync the updated translations (#3654) Co-authored-by: github-actions <> * Autosync the updated translations (#3655) Co-authored-by: github-actions <> * Autosync the updated translations (#3656) Co-authored-by: github-actions <> * Fix build web workflow (#3664) * Bumped desktop version to 2022.9.2 (#3541) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Add renovate config (#3341) * Add renovate config * Run linter * fix: typo in auto issues responses (#3670) * [PS-1198] Desktop / Browser: Accessibility - make TOTP countdown announce for assistive technology users (#2660) * Make totp countdown `aria-hidden`, add copy of countdown as `sr-only` inside totp button, only make it conditionally "exist" on parent focus * Make exact same changes to desktop totp * Tweak copy button accessible name approach instead of `aria-label`, which overrides the content of the button and, because JAWS has trouble announcing the live region in the desktop app, results in JAWS not announcing ANY countdown at all, this at least announces the current countdown number when the button receives focus in JAWS * Add `aria-atomic="true"` avoid JAWS/Firefox only announcing the specific digit that updates, rather than the number as a whole * Update, run prettier, lint * Remove orphaned jslibs Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com> * [EC-582] Add domain object serialization (#3623) * Cloudops 165 (#3661) * Upload artifacts to R2 after we do S3. * Added beta check line to R2 upload * [SM-265] Add eslint rule forbidding get().value (#3671) * [PS-1514] Do not subscribe to activeAccount-observable and execute load asynchronously (#3608) * Fix async subscribe * Revert "[PS-1066] Browser and Desktop - SSO User does not see Update Master Password screen after Owner does a Admin Password Reset (#3207)" This reverts commit 0eda418. * Add organization-options menu to single org (#3678) * Add staged rollout desktop workflow (#3702) * fixes (#3708) * added 2fa enabled (#3711) * [CL-42] Add code color (#3662) * [EC-558] Reflecting async progress on buttons and forms (#3548) * [EC-556] feat: convert button into component * [EC-556] feat: implement loading state * [EC-556] feat: remove loading from submit button * [EC-556] fix: add missing import * [EC-556] fix: disabling button using regular attribute * [EC-556] feat: implement bitFormButton * [EC-556] feat: use bitFormButton in submit button * [EC-556] fix: missing import * [EC-558] chore: rename file to match class name * [EC-558] feat: allow skipping bitButton on form buttons * [EC-558]: only show spinner on submit button * [EC-558] feat: add new bit async directive * [EC-558] feat: add functionToObservable util * [EC-558] feat: implement bitAction directive * [EC-558] refactor: simplify bitSubmit using functionToObservable * [EC-558] feat: connect bit action with form button * [EC-558] feat: execute function immediately to allow for form validation * [EC-558] feat: disable form on loading * [EC-558] chore: remove duplicate types * [EC-558] feat: move validation service to common * [EC-558] feat: add error handling using validation service * [EC-558] feat: add support for icon button * [EC-558] fix: icon button hover border styles * [EC-558] chore: refactor icon button story to show all styles * [EC-558] fix: better align loading spinner to middle * [EC-558] fix: simplify try catch * [EC-558] chore: reorganize async actions * [EC-558] chore: rename stories * [EC-558] docs: add documentation * [EC-558] feat: decouple buttons and form buttons * [EC-558] chore: rename button like abstraction * [EC-558] chore: remove null check * [EC-558] docs: add jsdocs to directives * [EC-558] fix: switch abs imports to relative * [EC-558] chore: add async actions module to web shared module * [EC-558] chore: remove unecessary null check * [EC-558] chore: apply suggestions from code review Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * [EC-558] fix: whitespaces * [EC-558] feat: dont disable form by default * [EC-558] fix: bug where form could be submit during a previous submit * [EC-558] feat: remove ability to disable form Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * Forbid substitute (#3734) * [SG-720] Trim c null characters getting padded at end of messages (#3724) * Trim everything at the end of decrypted payload before parsing * Clarify comment * Use char code check for nulls * Extract trim code to function * make char codes constants * Update download artifact action (#3735) * Mark modalService.openViewRef as deprecated (#3697) * [EC-558] chore: cleanup unused code (#3740) * [EC-377] Transition Policy service into providing observables (#3259) * Added abstractions for PolicyApiService and PolicyService * Added implementations for PolicyApiService and PolicyService * Updated all references to new PolicyApiService and PolicyService * Deleted old PolicyService abstraction and implementation * Fixed CLI import path for policy.service * Fixed main.background.ts policyApiService dependency for policyService * Ran prettier * Updated policy-api.service with the correct imports * [EC-377] Removed methods from StateService that read policies * [EC-377] Updated policy service getAll method to use observable collection * [EC-377] Added first unit tests for policy service * [EC-377] Added more unit tests for Policy Service * [EC-376] Sorted methods order in PolicyApiService * [EC-376] Removed unused clearCache method from PolicyService * [EC-376] Added upsert method to PolicyService * [EC-376] PolicyApiService putPolicy method now upserts data to PolicyService * [EC-377] Removed tests for deleted clearCache method * [EC-377] Added unit test for PolicyService.upsert * [EC-377] Updated references to state service observables * [EC-377] Removed getAll method from PolicyService and refactored components to use observable collection * [EC-377] Updated components to use concatMap instead of async subscribe * [EC-377] Removed getPolicyForOrganization from policyApiService * [EC-377] Updated policyAppliesToUser to return observable collection * [EC-377] Changed policyService.policyAppliesToUser to return observable * [EC-377] Fixed browser settings.component.ts getting vault timeout * Updated people.component.ts to get ResetPassword policy through a subscription * [EC-377] Changed passwordGenerationService.getOptions to return observable * [EC-377] Fixed CLI generate.command.ts getting enforcePasswordGeneratorPoliciesOnOptions * [EC-377] Fixed eslint errors on rxjs * [EC-377] Reverted changes on passwordGeneration.service and vaultTimeout.service * [EC-377] Removed eslint disable on web/vault/add-edit-component * [EC-377] Changed AccountData.policies to TemporaryDataEncryption * [EC-377] Updated import.component to be reactive to policyAppliesToUser$ * [EC-377] Updated importBlockedByPolicy$ * [EC-377] Fixed missing rename * [EC-377] Updated policyService.masterPasswordPolicyOptions to return observable * [EC-377] Fixed vaultTimeout imports from merge * [EC-377] Reverted call to passwordGenerationService.getOptions * [EC-377] Reverted call to enforcePasswordGeneratorPoliciesOnOptions * [EC-377] Removed unneeded ngOnDestroy * Apply suggestions from code review Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * [EC-377] Fixed login.component.ts and register.component.ts * [EC-377] Updated PolicyService to update vaultTimeout * [EC-377] Updated PolicyService dependencies * [EC-377] Renamed policyAppliesToUser to policyAppliesToActiveUser * [EC-377] VaultTimeoutSettings service now gets the vault timeout directly instead of using observables * [EC-377] Fixed unit tests by removing unneeded vaultTimeoutSettingsService * [EC-377] Set getDecryptedPolicies and setDecryptedPolicies as deprecated * [EC-377] Set PolicyService.getAll as deprecated and updated to use prototype.hasOwnProperty * [EC-565] Reverted unintended change to vaultTimeoutSettings that was causing a bug to not display the correct vault timeout * [EC-377] Removed unneeded destroy$ from preferences.component.ts * [EC-377] Fixed policy.service.ts import of OrganizationService Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> Co-authored-by: mimartin12 <77340197+mimartin12@users.noreply.github.com> * [CL-27] [EC-455] Ng-Select Integration (#3383) * [CL-27] Select -> Library initial commit * [EC-455] NG-Select Integration * Prettier * [EC-455] [CL-27] Add option for removing items on close // Added loading/no item found text defaults // Fixed disabled bg color // Added templated loading icon * [EC-455] [CL-27] Removed enter override // Fixed backspace removal // Clearing search on add // Gave label select states * [EC-455] [CL-27] Added copy from text to theme * [EC-455] [CL-27] Changed SimpleItemView to type - removed creation logic to shift responsibility to hosting component * [EC-455] [CL-27] Updated custom theme to include CSS variable colors * [CL-27] [EC-455] Initial pass at form field control // initial template for custom value accessor * [EC-455] working baseItem input * [EC-455] working value accessor * [EC-455] Completed FormFieldControl implemntation // fixed badge disabled bug * [EC-455] Prettier * [EC-455] Removed obsolete variables * [EC-455] Private value accessor functions * [EC-455] Cleaned up default variables * [EC-455] Imported Shared module to access i18n pipe // cleaned up string refs * [EC-455] Adjusted padding for clear button // Changed hover color to text-main // Fixed pipe import on stories * [EC-455] FormObj factory * [EC-455] FormObj factory * [EC-455] Updated FormFieldModule import/export statements * [EC-455] Null check ngControl // added strings * [EC-455] Fixed remaining null check // Added standalone story & input * [EC-455] Actually adding the null check * [EC-455] Removed injector logic // Removed Value Accessor PROVIDER // Self-assigned value accessor * [EC-455] Fixed ID copy pasta // Forwarded desribed by to focusable input // Abstracted input for label * [EC-455] Prettier * [DEVOPS-1014] Fix desktop autobump workflow (#3736) * Fix desktop autobump workflow * Fix desktop autobump workflow accoring to vince suggestions in mobile * Update ubuntu version * DEVOPS-915 - Automate Staged Rollouts for Desktop (#3704) * PS 1569 update on command listener (#3647) * Add windows to platform utils service Note, this will result in conflicts with several in-flight PRs, but is necessary for following commits. * Add necessary background service factories * Simplify autofill command * Remove noop event service * Fix linting issue caused by #3259 (#3743) * Bump Web version to 2022.10.0 (#3747) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [PS-1569] Fix spelling of totpServiceFactory (#3746) * Remove unzip step (#3749) * Remove unzip step (#3750) * Update Dry Run step and artifact path (#3751) * Update artifact steps in Web build worklfow (#3756) * [PS-1531]Sentence case browser (#3578) Copy updated. Transition browser strings to use sentence case for all UI elements, except the following terms: • Branded Names: Provider(s) + Provider Portal, Send(s) + Send, Directory Connector • Plan Names: Premium, Families, Teams, Enterprise * Add the cloudflare unzip back (#3758) * Change the download target for cloudflare deploy (#3759) * [PS-1194] Display Creation Date in Clients (#3181) * Add CreationDate to common libs * Add CreationDate to Browser * Add CreationDate to CLI * Add CreationDate to Desktop * Add CreationDate to Web * Update tests Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Bumped browser version to 2022.10.0 (#3764) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Autosync the updated translations (#3713) Co-authored-by: github-actions <> * Autosync the updated translations (#3714) Co-authored-by: github-actions <> * Autosync the updated translations (#3715) Co-authored-by: github-actions <> * Bumped cli version to 2022.10.0 (#3765) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Bumped desktop version to 2022.10.0 (#3766) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * edit CLI choco retrieve secret (#3767) * Add artifact extract step (#3773) * Update retrieve secrets steps in workflows (#3705) * update gitignore * Bumped desktop version to 2022.10.1 (#3778) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update-workflows-git-signing (#3725) * crowdin workflow update * version bump workflow update * pinned gha for importing gpg key * added steps for kv + updated import gpg key action * Updated crowdin workflow to utilize kv * [PS-1335] problem with dropped letters keypresses when searching vault from browser extension debounce (#3680) * PS-1335 - replace custom debounce with built-in debounce, extend time to 500ms * PS-1335 - replace custom autofocus with directive * PS-1335 - update access modifiers of observable variables * Update bwi-font files and icon stylesheet (#3780) * Autosync the updated translations (#3785) Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> * Autosync the updated translations (#3784) Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> * Autosync the updated translations (#3783) Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> * [PS-1676] Resolve Send Filters being truncated (#3791) * fix typo: EEFLongWordList -> EFFLongWordList (#3742) Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com> * [SG-657] Use jest mock extended for unit test service mocks (#3690) * Use jest mock extended for unit test service mocks * Replace substitute with mock * Fix merge issues * [SM-288] Rename models to follow naming convention (#3795) * EC-601 Remove device verification UI from web to avoid confusing users (#3744) * Change trigger for desktop autobump (#3794) * Remove duplicate SECURITY.md file (#3808) * Inform that we track issues outside of Github (#3703) * Inform that we track issues outside of Github * Use checkboxes for info acknowledgement * [PS-1674] Correct truncation of ciphers in browser (#3792) * Create banner.stories.mdx (#3695) * Create banner.stories.mdx Added documentation for Banner component in Common * Update banner.stories.mdx Added comment to test verification * Update banner.stories.mdx Removing test comment * Trying our referencing stories in banner mdx * fix: build errors * Added stories for banner info, warning, danger * Formatting update libs/components/src/banner/banner.stories.ts Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * Update banner.stories.mdx Added list formatting to text for readability, added section for Accessibility * Update libs/components/src/stories/banner.stories.mdx Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com> * Update libs/components/src/stories/banner.stories.mdx Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com> * Updated banner.stories.mdx Added section for Accessibility, improvements to text formatting for readability Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com> Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com> * Use settings in base.json and merge config keys (#3804) * Add CI check to forbid filenames with capital letters in them (#3807) * [SM-296] Remove desktop security from the whitelist (#3822) * Whitelist 127.0.0.1:10000 for azurite (#3803) * Add job to close translation PRs (#3730) * Storybook docs structure (#3755) * updated naming of common to documentation * Add button docs * updated sort order Documentation is now above the component library and allows the general pages to come before the component specific ones. * fixed typos * updated file name * fixed typo in introduction.stories.mdx * updated banner.stories.mdx to match new docs structure * remove plural in button docs * [EC-450] Added show SCIM key toggle button (#3682) * [EC-450] Added show SCIM key toggle button * [EC-450] Add id on the showApiKey button * [SM-288] Rename requests and responses to follow naming convention (#3806) * [PS-817] Add Generate Password Shortcut to MV3 (#3575) * Add generate command * Add JSDoc * Minor improvements * Remove unneeded comment * Make some properties optional * Remove main.background.ts changes * One more * Lint * Make all but length optional * Address PR feedback * Move generate command code to command * Address PR feedback * Use new alarm scheme * Let feature handle state keys Moves to a feature folder and creates clipboard-module level state handler functions. StateService is being paired down to storage routing, so we are handling storage specifics in-module. Co-authored-by: Justin Baur <justindbaur@users.noreply.github.com> Co-authored-by: Daniel Smith <djsmith85@users.noreply.github.com> * Missed some changes Co-authored-by: Matt Gibson <mgibson@bitwarden.com> Co-authored-by: Justin Baur <justindbaur@users.noreply.github.com> Co-authored-by: Daniel Smith <djsmith85@users.noreply.github.com> * Update clear-clipboard path (#3826) PR #3575 merged in master just before the file name changes were enforced in CI * [SM-245] Change register and prelogin to always use api (#3553) * PS-1620 Move AccountService.delete to Internal (#3687) * Move AccountService.delete to Internal * Remove unnecessary promise * Tweak styles for selects and desktop form groups (#3646) * Desktop/browser: explicitly define themed text `::selection` styles (#3675) * Build all browser MV3 artifacts (#3835) only uploading Chrome, Edge and Opera artifacts for now, as those support manifest V3 Also corrects build artifact to lower case. * Ps 1291 fix extension icon updates (#3571) * Add needed factories for AuthService WIP: Allow console logs * Add badge updates * Init by listener * Improve tab identification * Define MV3 background init * Init services in factories. Requires conversion of all factories to promises. We need to initialize in factory since the requester of a service doesn't necessarily know all dependencies for that service. The only alternative is to create an out parameter for a generated init function, which isn't ideal. * Improve badge setting * Use `update-badge` in mv2 and mv3 Separates menu and badge updates * Use update-badge everywhere * Use BrowserApi where possible * Update factories * Merge duplicated methods * Continue using private mode messager for now * Add static platform determination. * Break down methods and extract BrowserApi Concerns * Prefer strict equals * Init two-factor service in factory * Use globalThis types * Prefer `globalThis` * Use Window type definition updated with Opera Co-authored-by: Justin Baur <justindbaur@users.noreply.github.com> * Distinguish Opera from Safari Opera includes Gecko, Chrome, Safari, and Opera in its user agent. We need to make sure that we're not in Opera prior to testing Safari. * Update import * Initialize search-service for update badge context * Build all browser MV3 artifacts only uploading Chrome, Edge and Opera artifacts for now, as those support manifest V3 Also corrects build artifact to lower case. * Remove individual dist Co-authored-by: Justin Baur <justindbaur@users.noreply.github.com> Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com> * Bumped browser version to 2022.10.1 (#3836) Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> * Fix about info not selectable/copyable (#3610) * DEVOPS-1016 - Fix Desktop/Browser pipelines to support hotfix process (#3828) * [SG-698] Passwordless Login with 2FA enabled does not redirect to 2FA page (#3820) * added 2fa enabled * added passwordless authentication to 2fa * passwordless strategy to authservice * changes to 2FA to allow email sending for passwordless * updated imports * [PS-1529]Sentence case web vault (#3577) * updated title case to sentence case also added grammatical improvement to confirmation messages * capitalized 'vault' also updated the term personal vault to individual vault * capitalized 'send' * capitalized 'provider' also caught some straggling lowercase 'vaults' * sentence case 'organizations,' 'owners', and 'admins' * updated more casing to sentence * lowercase vault * Updated Premium to title case * fixed typos * Fixed typos and removed 'disable' * updated two-step login terms * Fixed missed sentence casing * Fixed missed sentence case * lowercased groups fixed other missed sentence case items as well * fixe membership casing * uppercase plan casing addressed other comments from Fred. * casing on billing sync and trash * uppercase Social Security * fixed single sign-on casing fixed Enterprise policy casing * merging in master * replaced enabled * fixed typos Co-authored-by: Patrick <94560851+patrick-bitwarden@users.noreply.github.com> * Bump Web version to 2022.10.1 (#3837) Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> * [PS-1341] Add folder to item view (#3347) * Initial - add folder id to popup item view * Add folder service to view component * Move folder info higher in the item view as proper box * Add folder name handling to component * Add folder field to browser view * Add folder field to desktop view * Make folder field draggable following the merging of #3321 also make the folder field draggable * Use `<label>` and readonly `<input>` In anticipation of #3485 being merged * Changes from review - change input name to `folderName`, match it in the `for` attribute on the `<label>` - add an `if` check before querying folder names * Match `name` to `id` Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com> * Fix MultiSelect component styles and CSP error (#3841) * Update Web styles and CSP to support MultiSelect component - Include the MultiSelect module in the CL barrel file of exports - Import the MultiSelect scss into the Web styles.scss - Add the necessary sha256 hash to webpack CSP policy to support ngSelect inline styles * Undo removal of 127.0.0.1 from webpack CSP Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com> Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com> Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk> Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com> Co-authored-by: Colton Hurst <colton@coltonhurst.com> Co-authored-by: Addison Beck <addisonbeck1@gmail.com> Co-authored-by: Vincent Salucci <26154748+vincentsalucci@users.noreply.github.com> Co-authored-by: André Filipe da Silva Bispo <abispo@bitwarden.com> Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com> Co-authored-by: aj-rosado <109146700+aj-rosado@users.noreply.github.com> Co-authored-by: Todd Martin <> Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com> Co-authored-by: Gbubemi Smith <gsmithwalter@gmail.com> Co-authored-by: cyprain-okeke <108260115+cyprain-okeke@users.noreply.github.com> Co-authored-by: dynwee <onwudiweokeke@gmail.com> Co-authored-by: mimartin12 <77340197+mimartin12@users.noreply.github.com> Co-authored-by: ATJB <71517198+atjbramley@users.noreply.github.com> Co-authored-by: Matt Gibson <mgibson@bitwarden.com> Co-authored-by: Thomas Rittson <trittson@bitwarden.com> Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> Co-authored-by: Michał Chęciński <michal.checinski@outlook.com> Co-authored-by: J. Brock <joseph.brock@protonmail.com> Co-authored-by: Sammy Chang <sammychang2185@gmail.com> Co-authored-by: Shane Melton <smelton@bitwarden.com> Co-authored-by: Gbubemi Smith <gsmith@bitwarden.com> Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com> Co-authored-by: Michał Chęciński <mchecinski@bitwarden.com> Co-authored-by: Opeyemi <54288773+Eebru-gzy@users.noreply.github.com> Co-authored-by: Alexey Zilber <110793805+alex8bitw@users.noreply.github.com> Co-authored-by: cd-bitwarden <106776772+cd-bitwarden@users.noreply.github.com> Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com> Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com> Co-authored-by: Danielle Flinn <43477473+danielleflinn@users.noreply.github.com> Co-authored-by: Joseph Flinn <58369717+joseph-flinn@users.noreply.github.com> Co-authored-by: David Frankel <42774874+frankeld@users.noreply.github.com> Co-authored-by: sneakernuts <671942+sneakernuts@users.noreply.github.com> Co-authored-by: dgoodman-bw <109169446+dgoodman-bw@users.noreply.github.com> Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> Co-authored-by: Aaron Toponce <aaron.toponce@gmail.com> Co-authored-by: Federico Maccaroni <fedemkr@gmail.com> Co-authored-by: Jaclyn Touchstone <95641831+jtouchstonebw@users.noreply.github.com> Co-authored-by: Justin Baur <justindbaur@users.noreply.github.com> Co-authored-by: Patrick <94560851+patrick-bitwarden@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add new native message handler and implement new handshake request.
Code changes
apps/desktop/src/app/accounts/settings.component.html Add DDG setting to desktop settings
apps/desktop/src/app/accounts/settings.component.ts
libs/common/src/abstractions/state.service.ts Functionality to save new items in state
libs/common/src/models/domain/globalState.ts
libs/common/src/services/state.service.ts
apps/desktop/src/main/nativeMessaging.main.ts: handle messages for turning on/off the setting
apps/desktop/src/main.ts: Turn on native messaging service on startup if setting is
trueapps/desktop/src/services/nativeMessageHandler.service.ts: Add new service to handle the new messages. The
bw-handshakeis the current one implemented.apps/desktop/src/services/nativeMessaging.service.ts: Updates to existing native messaging service to use new service for new messages.
Before you submit