350 framework lifecycle #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angular 13 requires at least version 12.2. Upgrading node seems to break lint-staged. I upgraded that too and changed to pre-commit hook.
Angular 11 or one of the current dependency does not work with Node 16 - I postpone this upgrade for now and upgrade Angular and other dependencies first
following the upgrade guide here: https://update.angular.io/?l=2&v=11.0-13.0
slash.div divisions have been deprecated: https://sass-lang.com/documentation/breaking-changes/slash-div this commit is the result of running sass-migrator division for all files that emmited a warning. The migrator script replaces divisions by 2 (/ 2) with a multiplication (* 0.5) - this yields the same result but was a bit unecpected, since this is never mentioned in the docs (or I did not see it)
this upgrade resulted from running npx ng update as recommended in the upgrade guide. Strange enough - it also recommended to upagrade the cli to version 13 - but I think this should/ will be done later in the guide.
ng-bootstrap required angular 12 - and prevented the migration to angular 13
ng-select@6 defines a peer dependency to angular 12 and needs to be upgraded before upgrading to angular 13
this is the result of running the migration script from https://update.angular.io/?l=2&v=11.0-13.0 Compiling the componenent my-absences-abstract-confirm failed probably due to the new typescript version
tslint is not supported with angular 13 - move to eslint with a bare bones setup (only recommended styles + prettier) linting on commit is disabled for now because its failing for now, but I want to commit the current step in the migration process
the new eslint setup discourages empty lifecycle methods and reports the following error: Lifecycle methods should not be empty @angular-eslint/no-empty-lifecycle-method
eslint complains about negated async pipes with the following error: Async pipe results should not be negated... the rule is: @angular-eslint/template/no-negated-async
you should always use === or !== to avoid type coersion in javascript/ typescript. Enforced by the eslint rule @angular-eslint/template/eqeqeq
eslint reports this method as an issue, but angular throws errors in the console if this method is missing. This error is then reported in the application - ignore the rule for this line
the eslint rule enforced strict comparisons - but the tests did not properly setup the loading observable
ng-bootstrap requires bootstrap 4
caebr
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destroy$' den generischen Typhinzfügen - weil sonstdestroy$.next()` nicht compiliert.Mit Angular 13 kann nicht mehr
tslintverwendet werden - darum machen wir das Linting neu miteslint- statt einer spezifischen Konfiguration für die Webapp-Schulverwaltung habe ich im die default/ recommended Settings für Angular genommen. Zusätzlich (wie bisher) ergänzt mit Prettier.Die neuen eslint Rules haben dann einige Fehler geworfen:
onIinit()) dürfen nicht mehr leer sein.*ngIf="!(state.loading$ | async);Mit Angular 13 kommt auch ein neuer Sass Compiler - Division mit Slash
\ist deprecated - mittels Migrationsstool konnten diese Warnings automatisch behoben werden.Node wurde ebenfalls auf die neueste Version aktualisiert (lts/gallium)