350 framework lifecycle

.eslintrc.json

@@ -0,0 +1,48 @@
+{
+  "root": true,
+  "ignorePatterns": ["projects/**/*"],
+  "overrides": [
+    {
+      "files": ["*.ts"],
+      "parserOptions": {
+        "project": ["tsconfig.json", "e2e/tsconfig.json"],
+        "createDefaultProgram": true
+      },
+      "extends": [
+        "plugin:@angular-eslint/recommended",
+        "plugin:@angular-eslint/template/process-inline-templates"
+      ],
+      "rules": {
+        "@angular-eslint/component-selector": [
+          "error",
+          {
+            "prefix": "erz",
+            "style": "kebab-case",
+            "type": "element"
+          }
+        ],
+        "@angular-eslint/directive-selector": [
+          "error",
+          {
+            "prefix": "erz",
+            "style": "camelCase",
+            "type": "attribute"
+          }
+        ]
+      }
+    },
+    {
+      "files": ["*.html"],
+      "extends": ["plugin:@angular-eslint/template/recommended"],
+      "rules": {}
+    },
+    {
+      "files": ["*.html"],
+      "excludedFiles": ["*inline-template-*.component.html"],
+      "extends": ["plugin:prettier/recommended"],
+      "rules": {
+        "prettier/prettier": ["error", { "parser": "angular" }]
+      }
+    }
+  ]
+}

.github/workflows/buildDeploy.yml

@@ -12,26 +12,26 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [10.x]
-    
+        node-version: [lts/gallium]
+
     steps:
     - uses: actions/checkout@v2
-    
+
     - name: Use Node.js ${{ matrix.node-version }}
       uses: actions/setup-node@v2
       with:
         node-version: ${{ matrix.node-version }}
         cache: npm
 
-    - name: Build 🏭 
+    - name: Build 🏭
       run: |
         npm install
         npm run build:prod
         cp README.md dist && cp -r doc dist
         (cd dist && zip --recurse-paths webapp-schulverwaltung.zip *)
         mv dist/webapp-schulverwaltung dist/app
         sed -e "s~https://eventotest.api~$API_URL~g" dist/app/settings.example.js > dist/app/settings.js
-        
+
     - name: Deploy 🚀
       uses: JamesIves/github-pages-deploy-action@4.1.4
       with:

.github/workflows/lintAndTest.yml

@@ -10,22 +10,21 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [10.x, 14.x]
-    
+        node-version: [lts/gallium, lts/fermium]
+
     steps:
     - uses: actions/checkout@v2
-    
+
     - name: Use Node.js ${{ matrix.node-version }}
       uses: actions/setup-node@v2
       with:
         node-version: ${{ matrix.node-version }}
         cache: npm
-        
+
     - name: lint
       run: |
         npm install
         npm run lint
-        npm run lint:format
-
+
     - name: test
       run: npm run test:headless

.gitignore

@@ -33,6 +33,7 @@ speed-measure-plugin.json
 .history/*
 
 # misc
+/.angular/cache
 /.sass-cache
 /connect.lock
 /coverage

.husky/pre-commit

@@ -1,4 +1,4 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-lint-staged -r
+npx --no-install lint-staged -r

.nvmrc

@@ -1 +1 @@
-12
+lts/gallium

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+    "editor.formatOnSave": true
+}

angular.json

@@ -17,7 +17,6 @@
         "build": {
           "builder": "@angular-devkit/build-angular:browser",
           "options": {
-            "aot": true,
             "outputPath": "dist/webapp-schulverwaltung",
             "index": "src/index.html",
             "main": "src/main.ts",
@@ -49,7 +48,13 @@
                 "bundleName": "styles-notifications"
               }
             ],
-            "scripts": []
+            "scripts": [],
+            "vendorChunk": true,
+            "extractLicenses": false,
+            "buildOptimizer": false,
+            "sourceMap": true,
+            "optimization": false,
+            "namedChunks": true
           },
           "configurations": {
             "production": {
@@ -63,7 +68,6 @@
               "outputHashing": "none",
               "sourceMap": false,
               "namedChunks": false,
-              "aot": true,
               "extractLicenses": true,
               "vendorChunk": false,
               "buildOptimizer": true,
@@ -79,7 +83,8 @@
                 }
               ]
             }
-          }
+          },
+          "defaultConfiguration": ""
         },
         "serve": {
           "builder": "@angular-devkit/build-angular:dev-server",
@@ -111,10 +116,9 @@
           }
         },
         "lint": {
-          "builder": "@angular-devkit/build-angular:tslint",
+          "builder": "@angular-eslint/builder:lint",
           "options": {
-            "tsConfig": ["src/tsconfig.app.json", "src/tsconfig.spec.json"],
-            "exclude": ["**/node_modules/**"]
+            "lintFilePatterns": ["src/**/*.ts", "src/**/*.html"]
           }
         }
       }

doc/prettier.md

@@ -8,7 +8,7 @@ The module is integrated threefold:
 
 - Format on save in the editor, see https://prettier.io/docs/en/editors.html
 - Pre-commit hook in Git
-- Linting step in the CI pipeline: The build fails when a (TypeScript) file is not properly formatted (`npm run lint:format`)
+- Linting step in the CI pipeline: The build fails when a (TypeScript) file is not properly formatted (part of `npm run lint`)
 
 ## Update Prettier version
 

doc/setup-dev-environment.md

@@ -8,6 +8,7 @@ This project was generated with [Angular CLI](https://github.com/angular/angular
 
 - Install Node.js (preferably using [NVM](https://github.com/creationix/nvm))
 - Clone this repository
+- Execute `nvm use` to choose the correct Node version
 - Execute `npm install`
 - You're good to go