Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pet hate: showing "you're the first!" if you mean "the network is slow :-(" #26

Closed
jean opened this issue Sep 28, 2017 · 4 comments
Closed

Pet hate: showing "you're the first!" if you mean "the network is slow :-(" #26

jean opened this issue Sep 28, 2017 · 4 comments
Labels
Bug

Comments

@jean
Copy link

jean commented Sep 28, 2017

smartselectimage_2017-09-28-19-41-49
@waf
Copy link
Member

waf commented Sep 28, 2017

Agreed. We should have different messages for "no comments because we're loading" and "no comments because nobody commented"

@jean
Copy link
Author

jean commented Sep 29, 2017

Related: #30

@ches ches added the Bug label Jan 13, 2018
@djay
Copy link
Contributor

djay commented Jan 26, 2018

Fix is in #40 I believe

@waf
Copy link
Member

waf commented Jan 27, 2018

#40 will help with this message showing in error scenarios, but we'll need an additional PR that shows a loading message in the 2-3 seconds where we're waiting for the initial API request to complete (on page load).

@saiqulhaq saiqulhaq mentioned this issue Feb 10, 2018
Merged
@waf waf closed this as completed in #42 Feb 22, 2018
waf added a commit that referenced this issue Feb 22, 2018
@waf
Merge pull request #42 from saiqulhaq/master
c182348 
Fix #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ches @djay @jean @waf