Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user when there is error with github API request #40

Merged
merged 2 commits into from
Jan 27, 2018

Conversation

saiqulhaq
Copy link
Contributor

I would like to fix this option -> "put up apporiate message if we are rate limited. headers can tell us"

on the issue #30

but need to refactor github-issue.js to make the test

@djay djay changed the title minor fix Notify user when there is error with github API request Jan 26, 2018
@waf
Copy link
Member

waf commented Jan 27, 2018

Looks great! Thanks for your help. Nice choice with the axios-mock-adapter package.

@waf waf merged commit b1cfcc4 into bkkhack:master Jan 27, 2018
@waf waf mentioned this pull request Jan 27, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants