[pull] master from web-platform-tests:master #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Implement the constructor for `SharedStorageSetMethod`, etc. The error handling logic mirrors the existing sharedStorage.set(), etc. To allow code reuse, the sharedStorage.set(), etc. methods now creates the object and early return on exceptions. Note that even though we no longer explicitly call resolver->Reject() for sharedStorage.set(), etc., Chrome still converts thrown exceptions to rejected promises (to adhere to the specification [1]), so the end result is the same. This prepares for the implementation of the `sharedStorage.batchUpdate(methods)` method, as part of the Web Lock integration proposal: - WICG/shared-storage#199 - WICG/shared-storage#205 [1] https://w3ctag.github.io/promises-guide/#always-return-promises Bug: 373899210 Change-Id: Ie4edfedbe755afeb3db5ca557fd74482bac96138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6054694 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/main@{#1390779}
This CL implements the WebNN spec change proposal [1] that uses `AllowSharedBufferSource` for `MLGraphBuilder.constant()`. [1]: webmachinelearning/webnn#790 Bug: 380896836 Change-Id: Ib8fc58daaabf7493b08f9634daa1eeb08a50ad35 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050722 Reviewed-by: Austin Sullivan <asully@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1390750}
…scards a navigable. Differential Revision: https://phabricator.services.mozilla.com/D230663 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1932916 gecko-commit: 0bab96f9e1964a5670436d5af349d3a1671f768b gecko-reviewers: webdriver-reviewers, jdescottes
This patch wires up the Blink-side subresource integrity enforcement mechanism with the network-side SRIMessageSignature headers in order to give developers the ability to enforce integrity checks that validate a match between the public key specified in an `integrity` attribute and the key used to verify a valid signature. This is part of a chain of CLs implementing this feature: 1. [IntegrityMetadataSet] https://crrev.com/c/6054252 2. [Parsing 'ed25519'] https://crrev.com/c/6054782 3. [Matching/Enforcement] https://crrev.com/c/6055566 [You are here] Bug: 380783670 Change-Id: I04c1528ad2758b39186ff81482b49f95903f0688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6055566 Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1390866}
… A/B" This reverts commit 7f52df769dac418870a2d2a8fcd3f7c1f114405b. Reason for revert: suspected culprit for b/381980101 and b/381977849 Bug: 381980101, 381977849 Original change's description: > Enable 5 Protected Audience and Fenced Frame features in Mode A/B > > With the end of the Chrome-facilitated testing period, enable these features > in Modes A and B to provide a more consistent developer experience and > decrease the need for feature detection: > * PA Real Time Reporting > * PA multi-bid support > * PA deprecatedReplaceInURN via auction config > * PA multiple bidding contexts optimization > * FF allow cross-origin subframes to send reportEvent() beacons > > This was announced here: > https://groups.google.com/a/chromium.org/g/blink-dev/c/WgGGPElrG9o > > Change-Id: I7d26fb1ea908837557bf60cc8762245c409d0160 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049396 > Auto-Submit: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Shivani Sharma <shivanisha@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1390666} Change-Id: I4cf77749fb95b8de9cdc412c674f7edb9c481edd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6062886 Auto-Submit: Florian Jacky <fjacky@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Florian Jacky <fjacky@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#1390874}
Change-Id: Ifd3a5cba43381bf3af4d45c8bcc4dfd956403849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6062904 Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1390887}
Column fragments share their computed style with the parent multicol container, so be sure to ignore them for `anchor-name`. Bug: 381906272 Change-Id: I9bacc57acc7ebbc1622e5249f20a37d6c99c3cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6062892 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1390964}
The flaky WPT in the linked bug probably flakes because it relies on a fling gesture and the compositor is not ready at the time the test is run as it is still in paint holding. To fix this, as explained here [1], we can use waitForCompositorReady which will block until the compositor is producing frames. [1] https://issues.chromium.org/u/1/issues/380534434#comment5 Bug: 380534434 Change-Id: Ib7ec9303e1ef87431cca8315eb38ea574c52933f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6063900 Commit-Queue: David Awogbemila <awogbemila@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1390971}
Split these test cases up to make them easier to analyze, and fix numerous bugs with the test cases. https://bugs.webkit.org/show_bug.cgi?id=279455 https://bugs.webkit.org/show_bug.cgi?id=281004 https://bugs.webkit.org/show_bug.cgi?id=281005 https://bugs.webkit.org/show_bug.cgi?id=281016 https://bugs.webkit.org/show_bug.cgi?id=281011 https://bugs.webkit.org/show_bug.cgi?id=281059 https://bugs.webkit.org/show_bug.cgi?id=281060 https://bugs.webkit.org/show_bug.cgi?id=281065 https://bugs.webkit.org/show_bug.cgi?id=281087 https://bugs.webkit.org/show_bug.cgi?id=281094 https://bugs.webkit.org/show_bug.cgi?id=281145 https://bugs.webkit.org/show_bug.cgi?id=281146 https://bugs.webkit.org/show_bug.cgi?id=281151 https://bugs.webkit.org/show_bug.cgi?id=281148 https://bugs.webkit.org/show_bug.cgi?id=281463 https://bugs.webkit.org/show_bug.cgi?id=281438 https://bugs.webkit.org/show_bug.cgi?id=282397 https://bugs.webkit.org/show_bug.cgi?id=282340 https://bugs.webkit.org/show_bug.cgi?id=282352 https://bugs.webkit.org/show_bug.cgi?id=282717 https://bugs.webkit.org/show_bug.cgi?id=282836 https://bugs.webkit.org/show_bug.cgi?id=282850 https://bugs.webkit.org/show_bug.cgi?id=282841 https://bugs.webkit.org/show_bug.cgi?id=282993 https://bugs.webkit.org/show_bug.cgi?id=283004 https://bugs.webkit.org/show_bug.cgi?id=283060 https://bugs.webkit.org/show_bug.cgi?id=282992 https://bugs.webkit.org/show_bug.cgi?id=283068 https://bugs.webkit.org/show_bug.cgi?id=283940
This optimization avoids parsing and manipulating PNGs (expensive) if the hashes are equal and indicate no difference, even if the reftest has a fuzzy tolerance. Not a functional change.
It is not possible for elements to know if the lang attribute has changed for one of its ancestors. This change propagates lang attribute updates down the tree. The Permission Element listens to this change and updates the text accordingly. Bug: 374677445 Change-Id: Ic41c90a13f3fbb1faecc8298993bc74cb185137e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6003767 Auto-Submit: Ravjit Uppal <ravjit@chromium.org> Reviewed-by: Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391078}
w3c/csswg-drafts#10908 (comment) Bug: 379985080 Change-Id: Ic33e948c76c6fc9a53146735bd060e01a49d13dc AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6065538 Auto-Submit: Traian Captan <tcaptan@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Traian Captan <tcaptan@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391128}
The failures show that some builders are getting a max channel difference of 2 and a total pixels different of 5. This patch adjusts the parameters to allow a total number of pixels different to be 0-20 instead of exactly 20. Fixed: 380810022 Change-Id: Ia0e3bf9d5544cbf645ce515329e161dadb8f8f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050704 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391132}
…are of fractional coordinates `screenX`, `screenY`, `clientX`, `clientY`, `x`, `y`, `offsetX` and `offsetY` are now `double`. This patch makes the event classes aware of DOM events. Currently, Chrome allows fractional values only for pointer events whose type is not `click`, `auxclick` nor `contextmenu` (this exception is defined by the Pointer Events spec). Therefore, this patch follows them. I'm not sure about the untrusted events of non-pointer events, `click`, `auxclick` and `contextmenu`. Chrome does check whether it's trusted or not before applying `std::floor` or `std::round` at getter methods (I think that using `std::round` in `offsetX` and `offsetY` is their bug at least for untrusted events). This patch follows them for now but has a pref to allow for all untrusted events. Finally, for aligning to Chrome, this patch makes `click`, `auxclick` and `contextmneu` keep using integer coordinates because it's recommended by the Pointer Events spec. Note that this changes the logic in `Event::GetPageCoords`. It rounded the client point and scroll point before adding them. Similarly, `Event::GetOffsetCoords` too. It rounded the client point before transforming it. Therefore, in strictly speaking, this changes the behavior of other events which keep returning integer coordinates. However, I don't see any issues in our CI. So, for making the code simpler, let's use it and once we got some regression reports caused by this, let's make them take additional param to round the points to integer done in the traditional code. Differential Revision: https://phabricator.services.mozilla.com/D222728 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1680669 gecko-commit: 0ea945553f63659b99fd37265c5e7a764f70504d gecko-reviewers: smaug, emilio, webdriver-reviewers
…`double The values may be used with the coords of `MouseEvent`. Therefore, they need to be `double` right now. Differential Revision: https://phabricator.services.mozilla.com/D222729 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1680669 gecko-commit: aad5ccb93e0b10bc7d8db967125f5ce6c9d9bbaf gecko-reviewers: smaug
… A/B" This reverts commit b550c350a6ac01554b5d25c999d8d58b9389f289. Reason for revert: Turned out to not be the cause of b/381980101 and b/381977849 as they continued after the revert, and look to be WPT cross-talk for which mitigations are already in progress (e.g. https://crrev.com/1388378) Original change's description: > Revert "Enable 5 Protected Audience and Fenced Frame features in Mode A/B" > > This reverts commit 7f52df769dac418870a2d2a8fcd3f7c1f114405b. > > Reason for revert: suspected culprit for b/381980101 and b/381977849 > > Bug: 381980101, 381977849 > > Original change's description: > > Enable 5 Protected Audience and Fenced Frame features in Mode A/B > > > > With the end of the Chrome-facilitated testing period, enable these features > > in Modes A and B to provide a more consistent developer experience and > > decrease the need for feature detection: > > * PA Real Time Reporting > > * PA multi-bid support > > * PA deprecatedReplaceInURN via auction config > > * PA multiple bidding contexts optimization > > * FF allow cross-origin subframes to send reportEvent() beacons > > > > This was announced here: > > https://groups.google.com/a/chromium.org/g/blink-dev/c/WgGGPElrG9o > > > > Change-Id: I7d26fb1ea908837557bf60cc8762245c409d0160 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049396 > > Auto-Submit: Paul Jensen <pauljensen@chromium.org> > > Reviewed-by: Shivani Sharma <shivanisha@chromium.org> > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Commit-Queue: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1390666} > > Change-Id: I4cf77749fb95b8de9cdc412c674f7edb9c481edd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6062886 > Auto-Submit: Florian Jacky <fjacky@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Florian Jacky <fjacky@chromium.org> > Commit-Queue: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1390874} Bug: 381980101, 381977849 Change-Id: Ia963eac7362df95567f48fd8c0a4c07127df73d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6065414 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Alex Turner <alexmt@chromium.org> Owners-Override: Victor Tan <victortan@chromium.org> Auto-Submit: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Victor Tan <victortan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391243}
RunResizeObserverSteps() used to NotifyResizeObservers() for all frames, but RunResizeObserverSteps() was only performed on the root frame, which caused trouble for some mechanisms when inside iframes: 1. Forgetting the size of disconnected elements. Test: forget-on-disconnect-in-iframe.html , which is based on auto-006.html 2. Updating the last successful position fallback. Test: last-successful-iframe.html is based on last-successful-basic.html 3. Default anchor scroll shift. Test: position-area-scrolling-003.tentative.html Bug: 373874012 Change-Id: I39657685689d41b7ae1f15d31aaf61e05f1ee9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6063590 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391245}
The existing code assumes that the supported data types for the input() and constant() methods are the same. This is not true on some platforms Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14-blink-rel,mac14.arm64-blink-rel Change-Id: Id0365b623500f9bdb815e3332c3e9cfe4689bf11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6064547 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391227}
…ility>.<tier and level>.*` Based on conversation with Chrome Media Team, we should only support valid mimetype for future new codecs, and drop the legacy usage of `hvc1`. Bug: 40276507 Change-Id: I69680bd85dc56b99595268b9d21663058125fa14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6064058 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sida Zhu <zhusida@bytedance.com> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391370}
I wanted to add these as I don't think U+1E9E (ẞ) for instance is currently covered. At least one output is Unicode 16 aligned. Tiny bit unclear if they all are. If not, this will be resolved soonish.
…he parent CSP and child CSP. This isn't specified yet, see the comments in <to-javascript-parent-initiated-check-csp-order.html>. Differential Revision: https://phabricator.services.mozilla.com/D229010 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1933142 gecko-commit: ef3240476ac544bb76056721e39f7889b70c4e59 gecko-reviewers: tschuster
There are few failures introduced by WPT import in the editing component where the editing includes insertHTML command alongwith the white-space CSS properties. This CL fixes the failing WPTs by setting the expectation as per the CSS specification linked below. This change only updates the expectation for the failing WPTs which were introduced by this[1] CL and seem to have wrong expectations. [1] https://crrev.com/c/5937916 [2] https://www.w3.org/TR/css-text-3/#white-space-property Bug: 373924023 Change-Id: I31f2e63275e986c37cc423c5b0c878296d8ee5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5960541 Reviewed-by: Siye Liu <siliu@microsoft.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Utkarsh Pathak <utpathak@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1391524}
…pshotted CSP is checked during task creation, not during task execution (#49403) Preparation for fixing <whatwg/html#4651>.
Per whatwg/html#10547, we should always consume the user activation even if the popup blocker is disabled or the window has permission to open a new window. Differential Revision: https://phabricator.services.mozilla.com/D230331 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1930458 gecko-commit: a63ca42b209f7b7eb5d84a897d4f7a6efacbf98c gecko-reviewers: smaug
Allowing ::column on ::before elements is not specifically mentioned in the spec, but a ::before element can be a multicol scroll container with generated content. There is also an assumption here that all properties fully cascade even if just a few actually have an effect. Bug: 365680822, 382090952 Change-Id: I73d725d4bbf071016d53fc5183f2b9cea177f9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6068466 Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391571}
This WPT test was added by Mozilla after they noticed abspos-related breakage in some sites after shipping parts of the `continue: collapse` line-clamp proposal. However, they did not mark` the test as tentative. This patch marks it as such, adds a link to the CSSWG issue, and fixes TestExpectations. This patch does not fix the breakage Mozilla found, although it will also affect our implementation when we ship it. We will wait until there is some agreement among the CSSWG about how to fix it. Bug: 40336192, 383825171 Change-Id: I848db7d4ceb4cc89a4e0714e49b5ab0c7e33795b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096224 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1397604}
Fixed: 382503562 Change-Id: I41697ad53564ba5db1cf755d9482662abc74ee09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6094963 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1397607}
This patch updates background-color and border-radius to the latest proposal here: w3c/csswg-drafts#10857 Change-Id: Icc6ec70d27cc9f1131f5e164b1db66e63e8847fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072270 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1397608}
Otherwise, the same incorrect result might be retrieved each attempt, which defeats the retry's purpose. Workaround for https://crbug.com/383612546
…ocus-without-user-activation According to discussion[1] in webappsec WG and WHATWG, we should allow tab focus from parent frame into its sub frame when permissions policy `focus-without-user-activation` is disabled on the iframe. [1]: w3c/webappsec-permissions-policy#273 (comment) Bug: 371112534 Change-Id: Iaf88e90fd314b7d0e3d44f88dd837476eb3da8d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5976473 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1397646}
This reverts commit b0d64404c5c3c10ac474752095c0ecea7501574a. Reason for revert: Failing consistently on a number of builders, e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/50289/overview. Original change's description: > Handle appearance value changes during <select> showPicker. > > When the appearance value changes as the result of the picker > opening (e.g. via `::picker(select):open {appearance:auto}` or > similar), we close the picker to avoid any oscillation or > nonsensical behavior. This CL implements this change. > > Fixed: 376097114,370536090,367426156 > Bug: 384394713 > Change-Id: Ic94b1c860782eba594e18fb4469e6826ae6c2d03 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6094831 > Auto-Submit: Mason Freed <masonf@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Commit-Queue: Mason Freed <masonf@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1397591} Bug: 384394713 Change-Id: I99a287e125cdf88f6933111181e1a2bdcaf7576d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6103306 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Reilly Grant <reillyg@chromium.org> Owners-Override: Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1397653}
…header Parse "options;with_lock=xxx" into the `with_lock` parameter. If multiple "options" Items appear in the List, the last one will be used. The parsed value is passed to the browser process's `BatchUpdate()` API in the lock manager. This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web Lock integration proposal: - WICG/shared-storage#199 - WICG/shared-storage#205 Bug: 373899210 Change-Id: Id041e92075b22988656a3db4f1a74792312ee422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072742 Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1397664}
Bug: 349927087 Change-Id: I41458da3cf03e78ec9c25fe3fddea343c3e982d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6054825 Reviewed-by: Jiacheng Guo <gjc@google.com> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1397739}
This matches other browsers, and was kinda what was intended with the content empty check and such, I believe. Differential Revision: https://phabricator.services.mozilla.com/D232375 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1936549 gecko-commit: f298f75ad50e64e0ca01b7331aa53b4ceebfeae9 gecko-reviewers: dshin
Change-Id: Ib56e1a43df5878cff02495f104ef88acf2236c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101878 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1397784}
In the spec, when updating the active marker the following is meant to ensure that if the previously active marker was focused we update the focus to the new active marker, From https://drafts.csswg.org/css-overflow-5/#active-scroll-marker "If active marker was the last-focused element of the group, focus active marker". Fixed: 384391190 Change-Id: If629a73fae1613f0c12b0f9cff796e46407890c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097240 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1397817}
As the spec for these pseudo elements is mature enough and passed a few reviews, not making them .tentative. Bug: 332396355 Change-Id: I0e8973cfd3a1400f36913bb1a319374a11b2127b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098132 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1397851}
Open context with `window.open` to allow it to be closed by script.
It's possible to enter the anchor machinery while layout is dirty (from LocalFrame::UpdateScrollSnapshots()). That's bad in itself (see crbug.com/384523570 ), but it's equally bad to keep destroyed layout objects around. Therefore, store Element* instead of LayoutObject*. Bug: 381362589 Change-Id: Ifdc3b5b8c7d30977136fd9a2572ffc3354ab472d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097987 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1397911}
The script entries of LoAF for the promise-resolve invoker type do not provide sourceCharPosition. This CL enables the provision of the source position. - Introduced CapturePartialSourceLocationFromStack(v8::Isolate*) to retrieve both URL and starting character position of the currently executing script. - Added LongAnimationFrameSourceCharPosition runtime flag. Bug: 381529126 Test: - external/wpt/long-animation-frame/tentative/loaf-source- location.html - external/wpt/long-animation-frame/tentative/loaf-source-location-redirect.html Change-Id: I481a62d8eb4a5649fdddcff5b657d442335e8725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6060398 Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org> Commit-Queue: Joone Hur <joonehur@microsoft.com> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1397921}
Co-authored-by: wpt-pr-bot <wpt-pr-bot@users.noreply.github.com>
See discussion in whatwg/dom#1335. R=nrosenthal@chromium.org Bug: 40150299 Change-Id: I50aeafb913abb4b63480be4532254f367abf37b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097561 Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1397950}
…OY for Interop 2024 (#49767)
…tml>. Fixes w3c/trusted-types#568. Differential Revision: https://phabricator.services.mozilla.com/D232323 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1907849 gecko-commit: f7666d84884d03cfc7fb1286d9b1b3a383f33594 gecko-reviewers: smaug
…kerGlobalScope. Fixes w3c/trusted-types#567. Differential Revision: https://phabricator.services.mozilla.com/D232359 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1907849 gecko-commit: 33f7437132ed1729faaca96797f96c7712518852 gecko-reviewers: smaug
This CL fixes the problem that zoom affects the scroll amount by reusing scrolling logic from scroll manager code that is also used for page up and page down buttons handling. Fixed: 383552806 Change-Id: I581c91b99acf78159728b03e7f3173c6d1686a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097334 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1398125}
* `disableSessionHistoryInParent` is not setting in `firefox_android.py` because it expects a boolean. * `firefox.py` also expects a string. This patch changes the dictionary with `disableSessionHistoryInParent` to reference a boolean, checks for a string in `firefox.py` to properly handle boolean prefs, and commits the prefs in the right order. Differential Revision: https://phabricator.services.mozilla.com/D232086 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1936989 gecko-commit: 12c5037f7dbfa1568c654bb6fb060bea169d8984 gecko-reviewers: jgraham
Differential Revision: https://phabricator.services.mozilla.com/D232260 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1924505 gecko-commit: dcb87172b52f7a9ad32aeb48c41998712cb490f4 gecko-reviewers: asuth
Differential Revision: https://phabricator.services.mozilla.com/D232261 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1924505 gecko-commit: 353feca04484a06391e819f0db421dbeb6955291 gecko-reviewers: asuth
Consider:
```html
<div style="position: relative; width: 50px; height: 50px; border: solid; margin: 5px">
<div style="position: absolute; top: 0; bottom: 0; height: max-content">
<canvas width="25" height="25" style="background: cyan; height: 100%"></canvas>
</div>
</div>
```
In order to determine the inline min/max-content sizes, we need a
tentative block size as the input, which only takes extrinsic values
into account.
In this case `height: max-content` is intrinsic, so we were treating it
as `height: initial`, which would behave as a definite `height: stretch`.
Therefore, the canvas was able to resolve its percentage.
However, it seems weird to treat an explicitly intrinsic keyword in an
extrinsic way, and Blink doesn't do it. So now we treat the tentative
block size as indefinite, therefore the percentage behaves as auto.
This adds a new test, we were previously failing 6 subtests, now only 3.
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
The code in HTMLOptionElement::UpdateLabel was inconsistent with the code in SetTextOnlyRendering that does text-only rendering when there is a label attribute. This applies the one-line fix (although it might be worth considering future refactoring here). This was just something I noticed while looking at the code in order to investigate issue 353764798. Bug: 353764798 Change-Id: Id948098e9a507a580f73a28885bd99b703e7318a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6103332 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1398327}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )