-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume user activation when creating a new top-level traversable #10547
Consume user activation when creating a new top-level traversable #10547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks reasonable. It will only consume when actually creating a top-level traversable.
WPT tests will be added in https://bugzilla.mozilla.org/show_bug.cgi?id=1879820. |
Thanks! @zcorpan can you complete OP? |
The multi-global test highlights a difference between this PR and what is implemented in Chromium. currentNavigable is set by
https://html.spec.whatwg.org/#window-open-steps So the user activation is consumed in the entry global. But Chromium consumes in the relevant global per: web-platform-tests/wpt#49138 (comment) I think using the entry global makes sense if other things of the window open steps use that (as currently defined). |
Done. |
Corresponds to whatwg/html#10547 (cherry picked from commit 2c7e73072685d241585795c8f82bb9f1b1840c98)
Corresponds to whatwg/html#10547 (cherry picked from commit 2c7e73072685d241585795c8f82bb9f1b1840c98)
….open (multi-global test), a=testonly Automatic update from web-platform-tests HTML: Consume user activation for window.open (multi-global test) See whatwg/html#10547 -- wpt-commits: 5ec8ba6d68f27d49a056cbf940e3bc9a8324c538 wpt-pr: 49138
….open (multi-global test), a=testonly Automatic update from web-platform-tests HTML: Consume user activation for window.open (multi-global test) See whatwg/html#10547 -- wpt-commits: 5ec8ba6d68f27d49a056cbf940e3bc9a8324c538 wpt-pr: 49138
….open (multi-global test), a=testonly Automatic update from web-platform-tests HTML: Consume user activation for window.open (multi-global test) See whatwg/html#10547 -- wpt-commits: 5ec8ba6d68f27d49a056cbf940e3bc9a8324c538 wpt-pr: 49138 UltraBlame original commit: 3da7235374ed270a493d09f34f3c394c87b74de9
….open (multi-global test), a=testonly Automatic update from web-platform-tests HTML: Consume user activation for window.open (multi-global test) See whatwg/html#10547 -- wpt-commits: 5ec8ba6d68f27d49a056cbf940e3bc9a8324c538 wpt-pr: 49138 UltraBlame original commit: 3da7235374ed270a493d09f34f3c394c87b74de9
….open (multi-global test), a=testonly Automatic update from web-platform-tests HTML: Consume user activation for window.open (multi-global test) See whatwg/html#10547 -- wpt-commits: 5ec8ba6d68f27d49a056cbf940e3bc9a8324c538 wpt-pr: 49138 UltraBlame original commit: 3da7235374ed270a493d09f34f3c394c87b74de9
Per whatwg/html#10547, we should always consume the user activation even if the popup blocker is disabled or the window has permission to open a new window. Differential Revision: https://phabricator.services.mozilla.com/D230331 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1930458 gecko-commit: a63ca42b209f7b7eb5d84a897d4f7a6efacbf98c gecko-reviewers: smaug
…ow; r=smaug Per whatwg/html#10547, we should always consume the user activation even if the popup blocker is disabled or the window has permission to open a new window. Differential Revision: https://phabricator.services.mozilla.com/D230331
Per whatwg/html#10547, we should always consume the user activation even if the popup blocker is disabled or the window has permission to open a new window. Differential Revision: https://phabricator.services.mozilla.com/D230331 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1930458 gecko-commit: a63ca42b209f7b7eb5d84a897d4f7a6efacbf98c gecko-reviewers: smaug
…ow; r=smaug Per whatwg/html#10547, we should always consume the user activation even if the popup blocker is disabled or the window has permission to open a new window. Differential Revision: https://phabricator.services.mozilla.com/D230331
Closes #10108.
window.open
)(See WHATWG Working Mode: Changes for more details.)
/document-sequences.html ( diff )