For blampe 7.3 #35
Merged
For blampe 7.3 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 17, 2024 14:42
Refactor for tidiness.
Regression Testing
---
Ran ./pre-push: SVG output of three files changed. Log excerpt:
=== RUN TestExamples
...
examples-regression_test.go:83: Failed to verify contents of 3 .svg files
examples-regression_test.go:130: Writing new SVG and HTML delta files into _examples_new/
examples-regression_test.go:149: complicated.html
examples-regression_test.go:149: regression.html
examples-regression_test.go:149: small-grids.html
...
Visual inspection of .html files in browser shows fix effective in
_examples_new/small-grids.{html,svg}, and no visually apparent change
in the other two sets of results.
|
Bug: Attempt documented above has failed: "Enable GitHub Action test beyond per-PR, to per-commit." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #25.
Enable GitHub Action test beyond per-PR, to per-commit.