Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For blampe 7.3 #35

Merged
merged 10 commits into from
Jul 17, 2024
Merged

For blampe 7.3 #35

merged 10 commits into from
Jul 17, 2024

Commits on Jul 17, 2024

  1. Test each commit individually upon pull request in GitHub

    dmullis committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    dae4ba5 View commit details
    Browse the repository at this point in the history

  2. Add a script to delete the products of pre-push.sh -w

    dmullis committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    dcef20b View commit details
    Browse the repository at this point in the history

  3. Enumerate examples/ for which SVG file contents may need to change 

    Refactor for tidiness.
    dmullis committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    62f9b91 View commit details
    Browse the repository at this point in the history

  4. Issue 25: Expose additional cases

    dmullis committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    3636a6a View commit details
    Browse the repository at this point in the history

  5. Upon regression failure, produce HTML for browser to surface differences

    dmullis committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6202386 View commit details
    Browse the repository at this point in the history

  6. Split 'canvas.go' along major data structure boundaries

    dmullis committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    0f098ef View commit details
    Browse the repository at this point in the history

  7. Refactor for readability; comments

    dmullis committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    1673e2c View commit details
    Browse the repository at this point in the history

  8. Better diagnostic upon abort for TAB char in input

    dmullis committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    3ed28be View commit details
    Browse the repository at this point in the history

  9. Issue blampe#25 -- Vertical edges of boxes run together 

    Regression Testing
---
Ran ./pre-push: SVG output of three files changed.  Log excerpt:

    === RUN   TestExamples
        ...
        examples-regression_test.go:83: Failed to verify contents of 3 .svg files
        examples-regression_test.go:130: Writing new SVG and HTML delta files into _examples_new/
        examples-regression_test.go:149: 	complicated.html
        examples-regression_test.go:149: 	regression.html
        examples-regression_test.go:149: 	small-grids.html
        ...

Visual inspection of .html files in browser shows fix effective in
_examples_new/small-grids.{html,svg}, and no visually apparent change
in the other two sets of results.
    dmullis committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b2022b0 View commit details
    Browse the repository at this point in the history

  10. Update generated SVG and Markdown files, for GitHub

    dmullis committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a4c2da8 View commit details
    Browse the repository at this point in the history