Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ENS avatar not available but name is #253 #260

Closed
wants to merge 44 commits into from

Conversation

FrancoAguzzi
Copy link
Contributor

No description provided.

FrancoAguzzi and others added 30 commits March 12, 2024 15:28
- added the grid sizes to the card
- added a new type called `isConfirmationModal` for confirmations when creating swaps in the swap station and when confirming accept swaps in swap offers. This boolean will define a single line of 5 squares
- changed the laptop/desktop squares from 4 to 3. They were being overflowed/cutted from the frame
- commented the entire placeholder code/logic
- removed unnecessary Math when calculating emptySquaresCount
- fixed overflows on offerSummary, hidden for X and auto for Y
- fixed gap for mobile-s (was cutting out of the frame)
- removed the scroll from the grids in all the offerSummary
fix: grid not showing in swap confirmation modal
- removed dashes from fill-rule and clip-rule

Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
- duplicated check on address

Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
…ddress-external-link

Feat/display address external link
…reset-shelf

clean shelf if network is not supported
…ter-disconnecting

ENS avatar don't reset after disconnecting the wallet
Co-authored-by: frankind.eth <49823133+FrancoAguzzi@users.noreply.github.com>
Copy link

vercel bot commented Mar 27, 2024

@FrancoAguzzi is attempting to deploy a commit to the Shared Blockful's projects Team on Vercel.

A member of the Team first needs to authorize it.

@@ -1,4 +1,4 @@
import { WalletIcon } from "@/components/01-atoms";
import { LoadingIndicator, WalletIcon } from "@/components/01-atoms";

Check failure

Code scanning / ESLint

Disallow unused variables Error

'LoadingIndicator' is defined but never used.
@@ -1,4 +1,4 @@
import { WalletIcon } from "@/components/01-atoms";
import { LoadingIndicator, WalletIcon } from "@/components/01-atoms";

Check failure

Code scanning / ESLint

Disallow unused variables Error

'LoadingIndicator' is defined but never used.
setFailedLoadingImage(true);
}
}
}, [avatarQueryStatus]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'avatarSrc'. Either include it or remove the dependency array.
@@ -98,6 +99,10 @@
checkForTokenApproval(token);
}, []);

useEffect(() => {
checkForTokenApproval(token);
}, [chain, token, authenticatedUserAddress]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'checkForTokenApproval'. Either include it or remove the dependency array.
@@ -35,7 +34,7 @@
setAuthenticatedUserTokensList([]);
setSearchedUserTokensList([]);
setInputAddress("");
}, [chain]);
}, [chain, authenticatedUserAddress]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has missing dependencies: 'setAuthenticatedUserTokensList', 'setInputAddress', and 'setSearchedUserTokensList'. Either include them or remove the dependency array.
Comment on lines +89 to +95
}, [
address,
isNetworkSupported,
authenticatedUserAddress,
validatedAddressToSwap,
destinyChain,
]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a missing dependency: 'getUserTokens'. Either include it or remove the dependency array.
export const getTokenContractAddress = (token: Token): EthereumAddress => {
if (!token) throw new Error("Token not defined");

let address: EthereumAddress | undefined = !token.contract

Check failure

Code scanning / ESLint

require `const` declarations for variables that are never reassigned after declared Error

'address' is never reassigned. Use 'const' instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants