Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Google Analytics Script #1770

Merged
merged 1 commit into from
Jun 12, 2023
Merged

update Google Analytics Script #1770

merged 1 commit into from
Jun 12, 2023

Conversation

leightkt
Copy link
Contributor

@leightkt leightkt commented Jun 9, 2023

Description

Update GA script on docs
https://www.notion.so/blocknative/Add-GA4-to-Onboard-Subdomain-5d7bde661f604aa1a450ef4d9ce33f9b

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • [NA ] Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • [NA] Add or update relevant information in the documentation

Docs Checklist

  • [NA] Include a screenshot of any changes (see docs README on running locally)
  • [NA] Add/update the appropriate package README (if applicable)
  • [NA] Add/update the related module in the docs demo (if applicable)
  • [NA] Add/update the related package in the docs/package.json file (if applicable)

@leightkt leightkt self-assigned this Jun 9, 2023
@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3-onboard-docs ✅ Ready (Inspect) Visit Preview Jun 9, 2023 6:45pm

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@leightkt leightkt merged commit 478ad48 into develop Jun 12, 2023
@leightkt leightkt deleted the ga-update branch June 12, 2023 19:56
leightkt added a commit that referenced this pull request Jun 27, 2023
* update Google Analytics Script (#1770)

* feat: add OneKey wallet  (#1739)

* feat: Support OneKey wallet

* fix: OneKey docs

* Update injected package.json version

* Update demo package.json

---------

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

* Fix: Connect view on safari mobile & Remove unnecessary validation check for autoSelect (#1773)

* working as expected

* Bump versions

* Remove testing css

* Remove testing code from demo

* feat: add blocto wallet (#1699)

* Release 2.24.1 (develop) (#1776)

* Release 2.24.1 (docs) (#1778)

* Update +page.md (#1775)

* Feature- update appMetadata (#1779)

* update versions

* Upgrade wallet connect v2 packages (#1788)

---------

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
Co-authored-by: ByteZhang <ByteZhang@protonmail.com>
Co-authored-by: jimmy.pan <pan831225@gmail.com>
Co-authored-by: vanes <vanessa.mercado24@gmail.com>
leightkt added a commit that referenced this pull request Jun 27, 2023
* update Google Analytics Script (#1770)

* feat: add OneKey wallet  (#1739)

* feat: Support OneKey wallet

* fix: OneKey docs

* Update injected package.json version

* Update demo package.json

---------

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

* Fix: Connect view on safari mobile & Remove unnecessary validation check for autoSelect (#1773)

* working as expected

* Bump versions

* Remove testing css

* Remove testing code from demo

* feat: add blocto wallet (#1699)

* Release 2.24.1 (develop) (#1776)

* Release 2.24.1 (#1777)

* Update +page.md (#1775)

* Feature- update appMetadata (#1779)

* update versions

* Upgrade wallet connect v2 packages (#1788)

---------

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
Co-authored-by: ByteZhang <ByteZhang@protonmail.com>
Co-authored-by: jimmy.pan <pan831225@gmail.com>
Co-authored-by: vanes <vanessa.mercado24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants