Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.24.1 #1777

Merged
merged 11 commits into from
Jun 15, 2023
Merged

Release 2.24.1 #1777

merged 11 commits into from
Jun 15, 2023

Conversation

leightkt
Copy link
Contributor

@leightkt leightkt commented Jun 14, 2023

Description

✨ Highlights

Docs:

📦 Changes per package

@web3-onboard/blocto: 2.0.0
@web3-onboard/core: 2.20.2
@web3-onboard/injected-wallets: ^2.10.1
@web3-onboard/react: 2.8.7
@web3-onboard/vue: 2.7.6

Adamj1232 and others added 8 commits June 9, 2023 10:26
* feat: Support OneKey wallet

* fix: OneKey docs

* Update injected package.json version

* Update demo package.json

---------

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
…eck for autoSelect (#1773)

* working as expected

* Bump versions

* Remove testing css

* Remove testing code from demo
@leightkt leightkt self-assigned this Jun 14, 2023
@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Install scripts web3 1.10.0
  • Install script: postinstall
  • Source: echo "Web3.js 4.x alpha has been released for early testing and feedback. Checkout doc at https://docs.web3js.org/ "
package.json via @dapperlabs/dappauth@2.0.5, packages/demo/package.json via @dapperlabs/dappauth@2.0.5
Network access @blocto/sdk 0.4.6 packages/blocto/package.json
Network access abortcontroller-polyfill 1.7.5 package.json via @dapperlabs/dappauth@2.0.5, packages/demo/package.json via @dapperlabs/dappauth@2.0.5
Network access web3-providers-http 1.10.0 package.json via @dapperlabs/dappauth@2.0.5, packages/demo/package.json via @dapperlabs/dappauth@2.0.5

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

What is network access?

This module accesses the network.

Packages should remove all network access that isn't functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore web3@1.10.0
  • @SocketSecurity ignore @blocto/sdk@0.4.6
  • @SocketSecurity ignore abortcontroller-polyfill@1.7.5
  • @SocketSecurity ignore web3-providers-http@1.10.0

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
@blocto/sdk 🆕 0.4.6 network +0 903 kB chiakic
@dapperlabs/dappauth 🆕 2.0.5 None +48 17 MB callmenick
@web3-onboard/core 🆕 2.20.2-alpha.1 None +0 654 kB cmeisl
@web3-onboard/core 🆕 2.19.2 None +0 661 kB cmeisl
@web3-onboard/injected-wallets 🆕 2.10.1-alpha.1 None +0 456 kB cmeisl
@web3-onboard/injected-wallets 🆕 2.9.0 None +0 449 kB cmeisl

🚮 Removed packages: @web3-onboard/venly@2.0.0-alpha.1

Footnotes

  1. https://docs.socket.dev


const connectedWallets = await onboard.connectWallet()
console.log(connectedWallets)
```
Copy link
Member

@Adamj1232 Adamj1232 Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add a code suggestion to add the build env updates here but cant because the file ends with ```

But adding this section at the end here would be good:

Build Environments

For build env configurations and setups please see the Build Env section here

Webpack 4

Node built-ins are automatically bundled in v4 so that portion is handled automatically.

Blocto support will require a Babel to compile from es6 if not already supported. See config for Babel and Webpack4 as follows

npm i --save-dev @babel/cli @babel/core @babel/node @babel/plugin-proposal-nullish-coalescing-operator @babel/plugin-proposal-optional-chaining @babel/plugin-syntax-bigint @babel/register
AND
npm i babel-loader

babel.config.js

module.exports = (api) => {
  api.cache(true)
  const plugins = [
    '@babel/plugin-proposal-optional-chaining',
    '@babel/plugin-proposal-nullish-coalescing-operator',
    '@babel/plugin-syntax-bigint'
  ]
  return { plugins }
}

webpack.config.js

config.module.rules = [
  ...otherModuleRules,
  {
    test: /\.js$/,
    exclude: (_) => !/node_modules\/(@web3auth|@ethereumjs)/.test(_),
    loader: 'babel-loader'
  }
]

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but g2g!

@leightkt leightkt merged commit c8ab47f into main Jun 15, 2023
@leightkt leightkt deleted the release/2.24.1 branch June 15, 2023 15:41
leightkt added a commit that referenced this pull request Jun 27, 2023
* Release 2.24.1 (docs) (#1778)

* Release 2.24.1 (#1777)

* update versions

---------

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
leightkt added a commit that referenced this pull request Jun 27, 2023
* update Google Analytics Script (#1770)

* feat: add OneKey wallet  (#1739)

* feat: Support OneKey wallet

* fix: OneKey docs

* Update injected package.json version

* Update demo package.json

---------

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

* Fix: Connect view on safari mobile & Remove unnecessary validation check for autoSelect (#1773)

* working as expected

* Bump versions

* Remove testing css

* Remove testing code from demo

* feat: add blocto wallet (#1699)

* Release 2.24.1 (develop) (#1776)

* Release 2.24.1 (#1777)

* Update +page.md (#1775)

* Feature- update appMetadata (#1779)

* update versions

* Upgrade wallet connect v2 packages (#1788)

---------

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
Co-authored-by: ByteZhang <ByteZhang@protonmail.com>
Co-authored-by: jimmy.pan <pan831225@gmail.com>
Co-authored-by: vanes <vanessa.mercado24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants