Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed buttons color at smart contract section. #2655

Closed
wants to merge 1 commit into from

Conversation

YegorSan
Copy link
Contributor

This PR is related to #2652 issue.

Motivation

  • Different color of buttons at smart contract page.

Changelog

Bug Fixes

  • Fixed color of a "Query" buttons at Read Contract section.

Checklist for your PR

@@ -19,7 +19,7 @@
</div>
<% end %>

<input type="submit" value='<%= gettext("Query")%>' class="button button-secondary button-xs py-0 mt-2" />
<input type="submit" value='<%= gettext("Query")%>' class="button btn-line button-xs py-0 mt-2" style="padding: 6px 8px!important;height: 26px;font-size: 11px;" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YegorSan should we create a class for those inline styles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbaranov As far as I understand , this partial is wrapped in elixir loop action, and each item should be rendered with already added inline style. I do understand, that it's not the best practice (but somebody are saying that it can increase page loading speed). If you confirm, I'll create a unique class for that element.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YegorSan My comment was only about clearance: styles in classes look better than inline styles in the source. My proposed change doesn't affect performance until those styles are loaded asynchronously but we don't load button styles async because they shouldn't visually change styles. Thus, let's leave it as is. But, please, close this PR and create PR to master branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbaranov As you requested, I am closing this PR , and created new one to master branch: #2671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants