Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed buttons color at smart contract section #2671

Merged
merged 5 commits into from
Sep 10, 2019

Conversation

YegorSan
Copy link
Contributor

@YegorSan YegorSan commented Sep 5, 2019

This PR is related to #2652 issue.

@vbaranov As you requested, I've re-created this PR to master branch, and now I am closing #2655 PR with the same update which was added to front-update branch.

Motivation

  • Different color of buttons at smart contract page.

Changelog

Bug Fixes

  • Fixed color of a "Query" buttons at Read Contract section.

Checklist for your PR

@vbaranov
Copy link
Member

vbaranov commented Sep 6, 2019

@YegorSan please add CHANGELOG entry

@YegorSan
Copy link
Contributor Author

YegorSan commented Sep 7, 2019

@vbaranov Hello. Added new CHANGELOG entry.

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YegorSan looks like your branch is not rebased onto the master branch of parent repo

Screenshot 2019-09-08 at 11 29 25

@YegorSan
Copy link
Contributor Author

YegorSan commented Sep 9, 2019

@vbaranov Hello Victor. Merging conflict was resolved. Could you please review?

@vbaranov
Copy link
Member

@YegorSan

Merging conflict was resolved. Could you please review?

Yes, but CHANGELOG entry is missing

@YegorSan
Copy link
Contributor Author

@vbaranov Changelog is updated.

CHANGELOG.md Outdated
@@ -1,6 +1,7 @@
## Current

### Features
- [#2671](https://github.com/poanetwork/blockscout/pull/2671) - fixed buttons color at smart contract section
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YegorSan it is not a feature. Let's move to Fix section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbaranov Moved new entry to fixes.

@vbaranov vbaranov merged commit 83e6971 into blockscout:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants