Fixed large scale in styleguide (deephaven#1890)

bmingles · Apr 29, 2024 · 707c733 · 707c733
1 parent b184a27
commit 707c733
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/packages/code-studio/src/styleguide/ListViews.tsx b/packages/code-studio/src/styleguide/ListViews.tsx
@@ -42,7 +42,10 @@ interface LabeledProps extends StyleProps {
 
 const LABELED_FLEX_CONTAINER_HEIGHTS = {
   gap: 10,
-  label: 21,
+  label: {
+    medium: 21,
+    large: 25.5,
+  },
 };
 
 function LabeledFlexContainer({
@@ -71,8 +74,10 @@ export function ListViews(): JSX.Element {
   );
 
   const [density, setDensity] = useState<ListViewProps['density']>('compact');
+
+  // Calculate the height of the single child example
   const singleChildExampleHeight =
-    LABELED_FLEX_CONTAINER_HEIGHTS.label +
+    LABELED_FLEX_CONTAINER_HEIGHTS.label[scale] +
     LABELED_FLEX_CONTAINER_HEIGHTS.gap +
     2 + // listview border
     LIST_VIEW_ROW_HEIGHTS[density ?? 'compact'][scale];

diff --git a/packages/components/src/spectrum/listView/ListViewWrapper.scss b/packages/components/src/spectrum/listView/ListViewWrapper.scss
@@ -22,9 +22,9 @@
 }
 
 .dh-list-view-wrapper-scale-large {
-  --dh-list-view-item-icon-compact: 30px;
-  --dh-list-view-item-icon-regular: 32px;
-  --dh-list-view-item-icon-spacious: 40px;
+  --dh-list-view-item-icon-compact: 20px;
+  --dh-list-view-item-icon-regular: 24px;
+  --dh-list-view-item-icon-spacious: 30px;
 }
 
 .dh-list-view-wrapper-density-compact {