Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.25.0-binance.24 Release #249

Merged
merged 12 commits into from
Jan 18, 2021
Merged

v0.25.0-binance.24 Release #249

merged 12 commits into from
Jan 18, 2021

Conversation

EnderCrypto
Copy link
Contributor

@EnderCrypto EnderCrypto commented Dec 28, 2020

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Fix IAVL Iterator Race Condition
Issue: cosmos/cosmos-sdk#5276
PR: cosmos/cosmos-sdk#5279

Remove unnecessary check to allow tx send (generate-only) to actually work offline
PR: cosmos/cosmos-sdk#4234

rickyyangz
rickyyangz previously approved these changes Dec 28, 2020
@EnderCrypto EnderCrypto changed the title Cosmos Bug-Fix [WIP]Cosmos Bug-Fix Dec 28, 2020
unclezoro
unclezoro previously approved these changes Dec 28, 2020
* remove header before insert it into fail ack package

* add missed proposal type
abelliumnt
abelliumnt previously approved these changes Jan 8, 2021
@EnderCrypto EnderCrypto changed the title [WIP]Cosmos Bug-Fix Cosmos Bug-Fix Jan 18, 2021
@EnderCrypto EnderCrypto changed the title Cosmos Bug-Fix v0.25.0-binance.24 Release Jan 18, 2021
TimeLockFee = 1e6
TimeUnlockFee = 1e6
TimeRelockFee = 1e6
TransferOwnershipFee = 1e6 // TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove TODO

rickyyangz
rickyyangz previously approved these changes Jan 18, 2021
@EnderCrypto EnderCrypto merged commit c96553a into master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants