[R4R] add 'm/' prefix to hd path #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 27, 2021 09:39
forcodedancing
changed the title
forcodedancing
changed the title
|
Please do test on HD, need ensure the address derivative is same and the function works. |
unclezoro
approved these changes
Dec 28, 2021
yutianwu
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes issues when 1) deriving hd wallet from a path; 2) formatting the path from a hd wallet.
Rationale
BIP-44 defines the general specifications of hd wallets. The path is BIP-44 is defined as
m / purpose' / coin_type' / account' / change / address_indexHowever,
mis missed in the earlier implementation. To fix this issue, we addedmto follow the specifications.Example
n/a
Changes