Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R] prepare for release v0.25.0 binance.25 #266

Merged
merged 14 commits into from
Jan 4, 2022
Merged

Conversation

forcodedancing
Copy link
Contributor

@forcodedancing forcodedancing commented Jan 4, 2022

Description

This pr includes the changes for v0.25.0 binance.25 release.

Rationale

n/a

Example

n/a

Changes

  • [sdk] #260 Bug fixes (e.g., unclosed iterator)
  • [stake] #261 Remove GetValidator caching to fix concurrency error
  • [keys] #263 Add 'm/' prefix to hd path
  • [core] #264 Upgrade Tendermint to v0.32.3-binance.6
    • Update go version to 1.16
    • Fix infinite recursion in Secp256k1 String() method

{&BIP44Params{44, 0, 0, true, 0}, "m/44'/0'/0'/1/0"},
{&BIP44Params{44, 0, 0, false, 1}, "m/44'/0'/0'/0/1"},
{&BIP44Params{44, 1, 1, true, 1}, "m/44'/1'/1'/1/1"},
{&BIP44Params{44, 118, 52, true, 41}, "m/44'/118'/52'/1/41"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please still keep 714, since it is a case from Binance Chain.

@forcodedancing forcodedancing merged commit c51134d into master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants