-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth/handler: check lists in body before broadcast blocks #2461
Merged
zzzckck
merged 2 commits into
bnb-chain:develop
from
NathanBSC:ValidateListsInBody_before_broadcast
May 15, 2024
Merged
eth/handler: check lists in body before broadcast blocks #2461
zzzckck
merged 2 commits into
bnb-chain:develop
from
NathanBSC:ValidateListsInBody_before_broadcast
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzckck
reviewed
May 15, 2024
NathanBSC
force-pushed
the
ValidateListsInBody_before_broadcast
branch
from
May 15, 2024 03:32
b26d0e0
to
84831ca
Compare
zzzckck
previously approved these changes
May 15, 2024
galaio
reviewed
May 15, 2024
galaio
previously approved these changes
May 15, 2024
galaio
reviewed
May 15, 2024
galaio
approved these changes
May 15, 2024
zzzckck
approved these changes
May 15, 2024
This was referenced Jun 11, 2024
Merged
buddh0
added a commit
to buddh0/bsc
that referenced
this pull request
Sep 4, 2024
…-chain#2461)" This reverts commit 0c0958f.
buddh0
added a commit
to buddh0/bsc
that referenced
this pull request
Sep 10, 2024
…-chain#2461)" This reverts commit 0c0958f.
buddh0
added a commit
to buddh0/bsc
that referenced
this pull request
Sep 18, 2024
…-chain#2461)" This reverts commit 0c0958f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eth/handler: check lists in body before broadcast blocks
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: