eth/handler: remove duplicate check for lists in body #2683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eth/handler: remove duplicate check for lists in body
Rationale
in this PR(#2461),
check for 3 lists
Uncles
,Transactions
,Withdrawals
is added.but indeed, most of them are useless, because
if block recieved by
handleBlockBodies
,Uncles
andTransactions
have been checked at https://github.com/bnb-chain/bsc/blob/master/eth/fetcher/block_fetcher.go#L718if block recieved by
handleNewBlock
Uncles
andTransactions
have been checked at https://github.com/bnb-chain/bsc/blob/master/eth/protocols/eth/handlers.go#L316so only add check for Withdrawals` is ok.
the check for
Transactions
cost not a little time when block is huge,by removing the dupicate check, a better performance can be acheived
so this PR have 2 commits,
the first one is to revert the above PR,
the second one add the check for Withdrawals`
Example
add an example CLI or API response...
Changes
Notable changes: