Skip to content

Commit

Permalink
src: move trace_event.h include to internal header
Browse files Browse the repository at this point in the history
Move the include from src/node.h to src/node_internals.h.

trace_event.h is not shipped in binary-only and headers-only tarballs,
making it currently impossible to build add-ons against them.

PR-URL: nodejs#10959
Refs: nodejs/citgm#226 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Loring <mattloring@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
  • Loading branch information
bnoordhuis committed Jan 26, 2017
1 parent 997af07 commit bfd3c7e
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion src/node.h
Original file line number Diff line number Diff line change
@@ -41,7 +41,6 @@

#include "v8.h" // NOLINT(build/include_order)
#include "node_version.h" // NODE_MODULE_VERSION
#include "tracing/trace_event.h"

#define NODE_MAKE_VERSION(major, minor, patch) \
((major) * 0x1000 + (minor) * 0x100 + (patch))
1 change: 1 addition & 0 deletions src/node_internals.h
Original file line number Diff line number Diff line change
@@ -8,6 +8,7 @@
#include "util-inl.h"
#include "uv.h"
#include "v8.h"
#include "tracing/trace_event.h"

#include <stdint.h>
#include <stdlib.h>

0 comments on commit bfd3c7e

Please sign in to comment.