add nodereport to lookup.json #226

gdams · 2016-11-17T16:23:37Z

nodereport is a foundation module that we should be testing. It seems to be passing on our IBM machines so looks like it should be okay

richardlau · 2016-11-17T19:27:40Z

It's mostly passing (see nodejs/node-report#24 and nodejs/node-report#26).

MylesBorins · 2016-11-17T19:32:39Z

CITGM on master https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/449/

gdams · 2016-11-17T20:54:09Z

Weird, was passing for me on OSX

richardlau · 2016-11-17T21:18:20Z

Looks like the compilation is not finding ares.h or zlib.h -- I'm wondering if this is a node-gyp bug when building with --nodedir as the headers under deps are moved to a different location (include/node) in Node.js' headers tarball.

richardlau · 2016-11-17T23:58:11Z

Yes, looks like a node-gyp bug. Have raised nodejs/node-gyp#1055.

richardlau · 2016-12-09T20:08:26Z

Build failures should have been addressed in nodereport's master by nodejs/node-report#30.

MylesBorins · 2016-12-09T20:53:34Z

if this CI run is green then LGTM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/472/

gdams · 2016-12-10T10:31:11Z

This won't have been fixed because you need to cut a new release of nodereport first.... @richardlau

richardlau · 2016-12-12T19:47:35Z

@GeorgeAdams95: nodereport v1.0.7 was released today.

gdams · 2016-12-13T13:44:33Z

@richardlau
CI 1: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/473/console
CI 2: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/476/

gibfahn · 2016-12-13T14:45:50Z

(Investigating the flaky issues in the earlier CIs)

CI 3: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/477/

MylesBorins · 2016-12-28T15:47:14Z

@gibfahn did that last ci run work? Job is no longer archived

gibfahn · 2016-12-28T16:11:25Z

@thealphanerd As I recall, there was an issue with CI that @richardlau was looking into, I'm not sure where it ended up.

richardlau · 2016-12-28T17:47:42Z

@gibfahn it ended up with you 😛. IIRC we were seeing intermittent makefile errors (no rule to make target) on the CI that I was unable to reproduce locally. I had a test fix in my fork of nodereport which you were going to test on the CI machines.

richardlau · 2017-01-20T12:36:33Z

The various CI runs have expired -- Would it be possible to rerun so we can capture the failure output in this pull request? (I'm still expecting it to fail as we haven't made changes since we've been unable to reproduce locally).

gdams · 2017-01-20T12:38:28Z

https://ci.nodejs.org/view/Node.js-citgm/job/gibfahn-citgm-smoker-more-platforms/79/console

richardlau · 2017-01-20T12:58:03Z

https://ci.nodejs.org/job/gibfahn-citgm-smoker-more-platforms/MACHINE=ppcbe-ubuntu1404/79/console
looks unrelated and is probably a problem with Node.js master:

verbose: npm-install:        | make: Entering directory `/tmp/102cb0d9-43da-48cd-9cec-e9c40b469a9f/nodereport/build'
verbose: npm-install:        | CXX(target) Release/obj.target/nodereport/src/node_report.o
warn: npm-install:        | In file included from ../node_modules/nan/nan.h:47:0,                                                                                        
warn:                     | from ../src/node_report.h:4,                                                                                                                 
warn:                     | from ../src/node_report.cc:1:                                                                                                                
warn:                     | /home/iojs/.node-gyp/8.0.0-nightly2017011949902124a9/include/node/node.h:44:33: fatal error: tracing/trace_event.h: No such file or directory
warn:                     | #include "tracing/trace_event.h"                                                                                                             
warn:                     | ^                                                                                                                                            
warn:                     | compilation terminated.                                                                                                                      
warn: npm-install:        | make: *** [Release/obj.target/nodereport/src/node_report.o] Error 1
verbose: npm-install:        | make: Leaving directory `/tmp/102cb0d9-43da-48cd-9cec-e9c40b469a9f/nodereport/build'
warn: npm-install:        | gyp ERR! build error
warn: npm-install:        | gyp ERR! stack Error: `make` failed with exit code: 2

richardlau · 2017-01-20T13:02:51Z

@gdams ran https://ci.nodejs.org/view/Node.js-citgm/job/gibfahn-citgm-smoker-more-platforms/80/console with Node 6 which replicates what we were seeing before:

gibfahn-citgm-smoker-more-platforms » ppcbe-ubuntu1404 completed with result SUCCESS

gibfahn-citgm-smoker-more-platforms » aix61-ppc64 completed with result SUCCESS
gibfahn-citgm-smoker-more-platforms » ppcle-ubuntu1404 completed with result SUCCESS

gibfahn-citgm-smoker-more-platforms » fedora22 completed with result FAILURE
gibfahn-citgm-smoker-more-platforms » osx1010 completed with result FAILURE
gibfahn-citgm-smoker-more-platforms » debian8-64 completed with result SUCCESS
gibfahn-citgm-smoker-more-platforms » fedora23 completed with result FAILURE
gibfahn-citgm-smoker-more-platforms » ubuntu1204-64 completed with result FAILURE
gibfahn-citgm-smoker-more-platforms » rhel72-s390x completed with result FAILURE
gibfahn-citgm-smoker-more-platforms » ubuntu1404-64 completed with result SUCCESS
gibfahn-citgm-smoker-more-platforms » ubuntu1604-64 completed with result FAILURE

The failure (e.g. https://ci.nodejs.org/job/gibfahn-citgm-smoker-more-platforms/MACHINE=fedora22/80/console):

verbose: npm-install:        | > nodereport@1.0.7 install /tmp/993291a5-2e40-4728-9b9a-d83e4e0f88c7/nodereport
verbose:                     | > node-gyp rebuild                                                             
verbose: npm-install:        | make: Entering directory '/tmp/993291a5-2e40-4728-9b9a-d83e4e0f88c7/nodereport/build'
warn: npm-install:        | make: *** No rule to make target '/tmp/993291a5-2e40-4728-9b9a-d83e4e0f88c7/nodereport/build/Release/nodereport.node', needed by '/tmp/993291a5-2e40-4728-9b9a-d83e4e0f88c7/nodereport/nodereport.node'.  Stop.
verbose: npm-install:        | CXX(target) Release/obj.target/nodereport/src/node_report.o
verbose:                     | CXX(target) Release/obj.target/nodereport/src/module.o     
warn: npm-install:        | make: *** Waiting for unfinished jobs....
verbose: npm-install:        | make: Leaving directory '/tmp/993291a5-2e40-4728-9b9a-d83e4e0f88c7/nodereport/build'

When we looked at the end of last year, this failure was not consistent across Linux distributions (it would fail on different distributions from run to run).

richardlau · 2017-01-20T13:40:33Z

@gdams ran my test fork in https://ci.nodejs.org/view/Node.js-citgm/job/gibfahn-citgm-smoker-more-platforms/82/console and everything passed (!) so I'll submit a PR to nodereport.

Move the include from src/node.h to src/node_internals.h. trace_event.h is not shipped in binary-only and headers-only tarballs, making it currently impossible to build add-ons against them. PR-URL: nodejs#10959 Refs: nodejs/citgm#226 (comment) Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matthew Loring <mattloring@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

gdams · 2017-02-09T15:30:49Z

okay so node-report is now landed and is fully fixed: https://ci.nodejs.org/view/Node.js-citgm/job/gibfahn-citgm-smoker-more-platforms/

CC @richardlau @gibfahn @MylesBorins

Move the include from src/node.h to src/node_internals.h. trace_event.h is not shipped in binary-only and headers-only tarballs, making it currently impossible to build add-ons against them. PR-URL: nodejs#10959 Refs: nodejs/citgm#226 (comment) Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matthew Loring <mattloring@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

richardlau mentioned this pull request Nov 17, 2016

Add CI testing for nodereport nodejs/node-report#18

Closed

gdams added the additional-modules label Nov 17, 2016

richardlau mentioned this pull request Nov 17, 2016

Fix include path when pointing to Node.js source nodejs/node-gyp#1055

Closed

richardlau mentioned this pull request Nov 24, 2016

Fix version reporting in NodeReport section nodejs/node-report#30

Closed

MylesBorins changed the title ~~add nodereport to lookup.json~~ [wip] add nodereport to lookup.json Jan 17, 2017

MylesBorins added the stalled label Jan 17, 2017

richardlau mentioned this pull request Jan 20, 2017

aix: skip command line check for test-fatal-error nodejs/node-report#41

Closed

gdams force-pushed the nodereporter branch 2 times, most recently from 171c836 to eedccea Compare January 20, 2017 13:18

gdams changed the title ~~[wip] add nodereport to lookup.json~~ add nodereport to lookup.json Jan 20, 2017

richardlau mentioned this pull request Jan 20, 2017

Fix source directory for install target nodejs/node-report#42

Closed

richardlau mentioned this pull request Jan 21, 2017

build: add tracing/trace_event.h to tarballs nodejs/node#10929

Closed

2 tasks

gdams force-pushed the nodereporter branch from eedccea to 2d10fd5 Compare February 9, 2017 15:14

This comment was marked as off-topic.

Sign in to view

lookup: add node-report

02d3f7c

gdams force-pushed the nodereporter branch from 2d10fd5 to 02d3f7c Compare February 9, 2017 22:47

gdams merged commit 02d3f7c into nodejs:master Feb 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add nodereport to lookup.json #226

add nodereport to lookup.json #226

gdams commented Nov 17, 2016 •

edited

Loading

richardlau commented Nov 17, 2016

MylesBorins commented Nov 17, 2016

gdams commented Nov 17, 2016

richardlau commented Nov 17, 2016

richardlau commented Nov 17, 2016

richardlau commented Dec 9, 2016

MylesBorins commented Dec 9, 2016

gdams commented Dec 10, 2016

richardlau commented Dec 12, 2016

gdams commented Dec 13, 2016 •

edited by gibfahn

Loading

gibfahn commented Dec 13, 2016

MylesBorins commented Dec 28, 2016

gibfahn commented Dec 28, 2016

richardlau commented Dec 28, 2016

richardlau commented Jan 20, 2017

gdams commented Jan 20, 2017

richardlau commented Jan 20, 2017

richardlau commented Jan 20, 2017

richardlau commented Jan 20, 2017

gdams commented Feb 9, 2017

This comment was marked as off-topic.

add nodereport to lookup.json #226

add nodereport to lookup.json #226

Conversation

gdams commented Nov 17, 2016 • edited Loading

richardlau commented Nov 17, 2016

MylesBorins commented Nov 17, 2016

gdams commented Nov 17, 2016

richardlau commented Nov 17, 2016

richardlau commented Nov 17, 2016

richardlau commented Dec 9, 2016

MylesBorins commented Dec 9, 2016

gdams commented Dec 10, 2016

richardlau commented Dec 12, 2016

gdams commented Dec 13, 2016 • edited by gibfahn Loading

gibfahn commented Dec 13, 2016

MylesBorins commented Dec 28, 2016

gibfahn commented Dec 28, 2016

richardlau commented Dec 28, 2016

richardlau commented Jan 20, 2017

gdams commented Jan 20, 2017

richardlau commented Jan 20, 2017

richardlau commented Jan 20, 2017

richardlau commented Jan 20, 2017

gdams commented Feb 9, 2017

This comment was marked as off-topic.

gdams commented Nov 17, 2016 •

edited

Loading

gdams commented Dec 13, 2016 •

edited by gibfahn

Loading