Cleanup (#1276)

boa-dev · May 23, 2021 · 62c99f5 · 62c99f5
1 parent 0dcf182
commit 62c99f5
Show file tree

Hide file tree

Showing 18 changed files with 150 additions and 104 deletions.
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -172,6 +172,29 @@ jobs:
           command: clippy
           args: -- --verbose
 
+  examples:
+    name: Examples
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2.3.4
+      - uses: actions-rs/toolchain@v1.0.7
+        with:
+          toolchain: stable
+          override: true
+          profile: minimal
+      - name: Cache cargo
+        uses: actions/cache@v2.1.5
+        with:
+          path: |
+            target
+            ~/.cargo/git
+            ~/.cargo/registry
+          key: ${{ runner.os }}-cargo-examples-${{ hashFiles('**/Cargo.lock') }}
+      - uses: actions-rs/cargo@v1
+        with:
+          command: build
+          args: --examples -v
+
   doc:
     name: Documentation check
     runs-on: ubuntu-latest

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/boa/Cargo.toml b/boa/Cargo.toml
@@ -38,7 +38,7 @@ chrono = "0.4.19"
 fast-float = "0.2.0"
 
 # Optional Dependencies
-measureme = { version = "9.1.1", optional = true }
+measureme = { version = "9.1.2", optional = true }
 once_cell = { version = "1.7.2", optional = true }
 
 [dev-dependencies]

diff --git a/boa/src/builtins/array/array_iterator.rs b/boa/src/builtins/array/array_iterator.rs
@@ -128,7 +128,10 @@ impl ArrayIterator {
         array_iterator.set_prototype_instance(iterator_prototype);
 
         let to_string_tag = WellKnownSymbols::to_string_tag();
-        let to_string_tag_property = DataDescriptor::new("Array Iterator", Attribute::CONFIGURABLE);
+        let to_string_tag_property = DataDescriptor::new(
+            "Array Iterator",
+            Attribute::READONLY | Attribute::NON_ENUMERABLE | Attribute::CONFIGURABLE,
+        );
         array_iterator.insert(to_string_tag, to_string_tag_property);
         array_iterator
     }

diff --git a/boa/src/builtins/bigint/mod.rs b/boa/src/builtins/bigint/mod.rs
@@ -68,7 +68,7 @@ impl BuiltIn for BigInt {
         .constructable(false)
         .property(
             to_string_tag,
-            "BigInt",
+            Self::NAME,
             Attribute::READONLY | Attribute::NON_ENUMERABLE | Attribute::CONFIGURABLE,
         )
         .build();

diff --git a/boa/src/builtins/json/mod.rs b/boa/src/builtins/json/mod.rs
@@ -46,7 +46,7 @@ impl BuiltIn for Json {
         let attribute = Attribute::READONLY | Attribute::NON_ENUMERABLE | Attribute::CONFIGURABLE;
 
         let json_object = ObjectInitializer::new(context)
-            .property(to_string_tag, "JSON", attribute)
+            .property(to_string_tag, Self::NAME, attribute)
             .function(Self::parse, "parse", 2)
             .function(Self::stringify, "stringify", 3)
             .build();

diff --git a/boa/src/builtins/map/map_iterator.rs b/boa/src/builtins/map/map_iterator.rs
@@ -149,7 +149,10 @@ impl MapIterator {
         map_iterator.set_prototype_instance(iterator_prototype);
 
         let to_string_tag = WellKnownSymbols::to_string_tag();
-        let to_string_tag_property = DataDescriptor::new("Map Iterator", Attribute::CONFIGURABLE);
+        let to_string_tag_property = DataDescriptor::new(
+            "Map Iterator",
+            Attribute::READONLY | Attribute::NON_ENUMERABLE | Attribute::CONFIGURABLE,
+        );
         map_iterator.insert(to_string_tag, to_string_tag_property);
         map_iterator
     }

diff --git a/boa/src/builtins/map/mod.rs b/boa/src/builtins/map/mod.rs
@@ -42,7 +42,6 @@ impl BuiltIn for Map {
         let _timer = BoaProfiler::global().start_event(Self::NAME, "init");
 
         let to_string_tag = WellKnownSymbols::to_string_tag();
-
         let iterator_symbol = WellKnownSymbols::iterator();
 
         let entries_function = FunctionBuilder::new(context, Self::entries)
@@ -66,7 +65,7 @@ impl BuiltIn for Map {
         )
         .property(
             to_string_tag,
-            "Map",
+            Self::NAME,
             Attribute::READONLY | Attribute::NON_ENUMERABLE | Attribute::CONFIGURABLE,
         )
         .property(

diff --git a/boa/src/builtins/math/mod.rs b/boa/src/builtins/math/mod.rs
@@ -48,7 +48,7 @@ impl BuiltIn for Math {
             .property("PI", f64::consts::PI, attribute)
             .property(
                 to_string_tag,
-                "Math",
+                Self::NAME,
                 Attribute::READONLY | Attribute::NON_ENUMERABLE | Attribute::CONFIGURABLE,
             )
             .function(Self::abs, "abs", 1)

diff --git a/boa/src/builtins/object/for_in_iterator.rs b/boa/src/builtins/object/for_in_iterator.rs
@@ -134,8 +134,10 @@ impl ForInIterator {
         for_in_iterator.set_prototype_instance(iterator_prototype);
 
         let to_string_tag = WellKnownSymbols::to_string_tag();
-        let to_string_tag_property =
-            DataDescriptor::new("For In Iterator", Attribute::CONFIGURABLE);
+        let to_string_tag_property = DataDescriptor::new(
+            "For In Iterator",
+            Attribute::READONLY | Attribute::NON_ENUMERABLE | Attribute::CONFIGURABLE,
+        );
         for_in_iterator.insert(to_string_tag, to_string_tag_property);
         for_in_iterator
     }

diff --git a/boa/src/builtins/reflect/mod.rs b/boa/src/builtins/reflect/mod.rs
@@ -57,7 +57,7 @@ impl BuiltIn for Reflect {
             .function(Self::set_prototype_of, "setPrototypeOf", 3)
             .property(
                 to_string_tag,
-                Reflect::NAME,
+                Self::NAME,
                 Attribute::READONLY | Attribute::NON_ENUMERABLE | Attribute::CONFIGURABLE,
             )
             .build();

diff --git a/boa/src/builtins/set/mod.rs b/boa/src/builtins/set/mod.rs
@@ -94,7 +94,11 @@ impl BuiltIn for Set {
             values_function,
             Attribute::WRITABLE | Attribute::NON_ENUMERABLE | Attribute::CONFIGURABLE,
         )
-        .property(to_string_tag, "Set", Attribute::CONFIGURABLE)
+        .property(
+            to_string_tag,
+            Self::NAME,
+            Attribute::READONLY | Attribute::NON_ENUMERABLE | Attribute::CONFIGURABLE,
+        )
         .build();
 
         (Self::NAME, set_object.into(), Self::attribute())

diff --git a/boa/src/builtins/set/set_iterator.rs b/boa/src/builtins/set/set_iterator.rs
@@ -144,7 +144,10 @@ impl SetIterator {
         set_iterator.set_prototype_instance(iterator_prototype);
 
         let to_string_tag = WellKnownSymbols::to_string_tag();
-        let to_string_tag_property = DataDescriptor::new("Set Iterator", Attribute::CONFIGURABLE);
+        let to_string_tag_property = DataDescriptor::new(
+            "Set Iterator",
+            Attribute::READONLY | Attribute::NON_ENUMERABLE | Attribute::CONFIGURABLE,
+        );
         set_iterator.insert(to_string_tag, to_string_tag_property);
         set_iterator
     }

diff --git a/boa/src/builtins/string/mod.rs b/boa/src/builtins/string/mod.rs
@@ -335,7 +335,7 @@ impl String {
 
         // Fast path returning NaN when pos is obviously out of range
         if pos < 0 || pos >= primitive_val.len() as i32 {
-            return Ok(Value::from(f64::NAN));
+            return Ok(Value::nan());
         }
 
         // Calling .len() on a string would give the wrong result, as they are bytes not the number of unicode code points
@@ -344,7 +344,7 @@ impl String {
         if let Some(utf16_val) = primitive_val.encode_utf16().nth(pos as usize) {
             Ok(Value::from(f64::from(utf16_val)))
         } else {
-            Ok(Value::from(f64::NAN))
+            Ok(Value::nan())
         }
     }