Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #1276

Merged
merged 3 commits into from
May 23, 2021
Merged

Cleanup #1276

merged 3 commits into from
May 23, 2021

Conversation

Razican
Copy link
Member

@Razican Razican commented May 22, 2021

While doing the rebase of #1272 I found some inconsistencies, so I tried to fix them here:

  • Upgraded Rust + JS dependencies
  • Improved style of some @@ToStringTag definitions, using Self::NAME when possible
  • Updated the Test262 submodule
  • Using Value::nan() instead of conversions
  • Added build tests for examples

Razican added 3 commits May 22, 2021 12:26
 - Upgraded Rust + JS dependencies
 - Improved style of some @@ToStringTag definitions
 - Updated the Test262 submodule
@Razican Razican added the enhancement New feature or request label May 22, 2021
@Razican Razican added this to the v0.12.0 milestone May 22, 2021
@Razican Razican requested review from HalidOdat, RageKnify and tofpie May 22, 2021 17:38
@github-actions
Copy link

Test262 conformance changes:

Test result master count PR count difference
Total 78,701 78,873 +172
Passed 26,535 26,498 -37
Ignored 15,519 15,604 +85
Failed 36,647 36,771 +124
Panics 28 27 -1
Conformance 33.72% 33.60% -0.12%

@github-actions
Copy link

Benchmark for 43c50ec

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 326.4±15.03ns 328.6±17.44ns -0.67%
Arithmetic operations (Full) 260.2±8.79µs 267.1±21.04µs -2.58%
Array access (Execution) 6.3±0.47µs 6.2±0.38µs +1.61%
Array access (Full) 293.3±14.93µs 297.2±21.24µs -1.31%
Array creation (Execution) 2.6±0.07ms 2.5±0.07ms +4.00%
Array creation (Full) 2.9±0.12ms 2.8±0.11ms +3.57%
Array pop (Execution) 848.5±42.54µs 794.7±30.65µs +6.77%
Array pop (Full) 1314.4±50.57µs 1258.6±36.42µs +4.43%
Boolean Object Access (Execution) 5.1±0.22µs 5.2±0.25µs -1.92%
Boolean Object Access (Full) 281.8±9.69µs 284.3±17.56µs -0.88%
Clean js (Execution) 630.1±28.02µs 621.8±28.90µs +1.33%
Clean js (Full) 921.5±39.55µs 934.1±49.91µs -1.35%
Clean js (Parser) 39.8±2.01µs 38.3±1.40µs +3.92%
Create Realm 396.3±24.43ns 384.1±16.66ns +3.18%
Dynamic Object Property Access (Execution) 5.2±0.32µs 5.2±0.26µs 0.00%
Dynamic Object Property Access (Full) 288.3±17.21µs 285.9±12.49µs +0.84%
Expression (Parser) 6.8±0.52µs 7.1±0.30µs -4.23%
Fibonacci (Execution) 784.2±22.99µs 805.1±34.02µs -2.60%
Fibonacci (Full) 1110.7±88.48µs 1076.2±51.11µs +3.21%
For loop (Execution) 21.5±1.10µs 21.6±1.04µs -0.46%
For loop (Full) 310.9±15.22µs 302.1±13.44µs +2.91%
For loop (Parser) 18.8±0.63µs 18.6±0.59µs +1.08%
Goal Symbols (Parser) 13.3±0.72µs 12.9±0.57µs +3.10%
Hello World (Parser) 3.8±0.19µs 3.7±0.13µs +2.70%
Long file (Parser) 729.0±55.83ns 727.9±31.79ns +0.15%
Mini js (Execution) 569.1±23.14µs 551.1±15.73µs +3.27%
Mini js (Full) 861.7±34.15µs 853.7±47.90µs +0.94%
Mini js (Parser) 34.7±1.54µs 33.2±1.24µs +4.52%
Number Object Access (Execution) 4.3±0.22µs 4.0±0.14µs +7.50%
Number Object Access (Full) 279.3±13.66µs 279.5±9.75µs -0.07%
Object Creation (Execution) 4.4±0.24µs 4.5±0.37µs -2.22%
Object Creation (Full) 287.4±15.26µs 281.1±11.36µs +2.24%
RegExp (Execution) 10.7±0.51µs 11.4±0.74µs -6.14%
RegExp (Full) 301.9±17.21µs 302.9±20.71µs -0.33%
RegExp Literal (Execution) 11.1±0.97µs 11.5±0.37µs -3.48%
RegExp Literal (Full) 293.4±11.33µs 318.0±14.03µs -7.74%
RegExp Literal Creation (Execution) 9.7±0.71µs 9.4±0.44µs +3.19%
RegExp Literal Creation (Full) 285.9±10.93µs 288.6±10.92µs -0.94%
Static Object Property Access (Execution) 4.6±0.23µs 4.6±0.14µs 0.00%
Static Object Property Access (Full) 285.4±11.83µs 288.8±22.11µs -1.18%
String Object Access (Execution) 7.1±0.30µs 7.1±0.25µs 0.00%
String Object Access (Full) 282.2±7.65µs 293.6±36.21µs -3.88%
String comparison (Execution) 6.5±0.33µs 6.5±0.38µs 0.00%
String comparison (Full) 311.7±22.27µs 287.7±18.09µs +8.34%
String concatenation (Execution) 5.1±0.20µs 5.1±0.16µs 0.00%
String concatenation (Full) 285.7±27.79µs 278.7±9.33µs +2.51%
String copy (Execution) 4.2±0.18µs 4.0±0.38µs +5.00%
String copy (Full) 277.0±14.15µs 271.9±9.05µs +1.88%
Symbols (Execution) 3.3±0.14µs 3.3±0.25µs 0.00%
Symbols (Full) 274.7±14.76µs 265.9±9.24µs +3.31%

@RageKnify
Copy link
Contributor

Isn't it strange that the number of passing tests went down?

@HalidOdat HalidOdat merged commit 62c99f5 into master May 23, 2021
@HalidOdat HalidOdat deleted the cleanup branch May 23, 2021 00:57
@Razican
Copy link
Member Author

Razican commented May 24, 2021

Isn't it strange that the number of passing tests went down?

A comparison using the same commit for Test262 shows that indeed there are 4 new failing tests. I will check what is happening. It seems that updating the Test262 they fixed some tests and this brings up the number of failures somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants