-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix RegExp
constructor return value when pattern is a regexp
#2880
Conversation
Test262 conformance changes
Fixed tests (10):
Broken tests (2):
|
Codecov Report
@@ Coverage Diff @@
## main #2880 +/- ##
==========================================
+ Coverage 51.22% 51.24% +0.01%
==========================================
Files 427 427
Lines 42516 42522 +6
==========================================
+ Hits 21780 21790 +10
+ Misses 20736 20732 -4
|
The broken test is caused by an unrelated bug that #2881 fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
bors r+
Pull request successfully merged into main. Build succeeded: |
RegExp
constructor return value when pattern is a regexpRegExp
constructor return value when pattern is a regexp
When
RegExp
constructor is called with a regexp it should return the same regexp, ifNewTarget
's constructor is the same.