Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix RegExp constructor return value when pattern is a regexp #2880

Closed
wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

When RegExp constructor is called with a regexp it should return the same regexp, if NewTarget's constructor is the same.

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Apr 29, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Apr 29, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,593 94,593 0
Passed 73,192 73,200 +8
Ignored 17,532 17,532 0
Failed 3,869 3,861 -8
Panics 0 0 0
Conformance 77.38% 77.38% +0.01%
Fixed tests (10):
test/built-ins/RegExp/S15.10.3.1_A1_T3.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.3.1_A1_T3.js (previously Failed)
test/built-ins/RegExp/S15.10.3.1_A1_T2.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.3.1_A1_T2.js (previously Failed)
test/built-ins/RegExp/S15.10.3.1_A1_T1.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.3.1_A1_T1.js (previously Failed)
test/built-ins/RegExp/S15.10.3.1_A1_T5.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.3.1_A1_T5.js (previously Failed)
test/built-ins/RegExp/S15.10.3.1_A1_T4.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.3.1_A1_T4.js (previously Failed)
Broken tests (2):
test/built-ins/RegExp/call_with_regexp_match_falsy.js [strict mode] (previously Passed)
test/built-ins/RegExp/call_with_regexp_match_falsy.js (previously Passed)

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #2880 (f817b80) into main (04ddeeb) will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
+ Coverage   51.22%   51.24%   +0.01%     
==========================================
  Files         427      427              
  Lines       42516    42522       +6     
==========================================
+ Hits        21780    21790      +10     
+ Misses      20736    20732       -4     
Impacted Files Coverage Δ
boa_engine/src/builtins/regexp/mod.rs 64.06% <80.00%> (+0.22%) ⬆️

... and 3 files with indirect coverage changes

@HalidOdat HalidOdat marked this pull request as ready for review April 29, 2023 21:27
@HalidOdat
Copy link
Member Author

The broken test is caused by an unrelated bug that #2881 fixes

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bors r+

bors bot pushed a commit that referenced this pull request Apr 29, 2023
When `RegExp` constructor is called with a regexp it should return the same regexp, if `NewTarget`'s constructor is the same.
@bors
Copy link

bors bot commented Apr 29, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix RegExp constructor return value when pattern is a regexp [Merged by Bors] - Fix RegExp constructor return value when pattern is a regexp Apr 29, 2023
@bors bors bot closed this Apr 29, 2023
@bors bors bot deleted the fix/regexp-constructor branch April 29, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants