-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - RegExp
constructor should call IsRegExp()
#2881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
Something isn't working
builtins
PRs and Issues related to builtins/intrinsics
labels
Apr 29, 2023
Test262 conformance changes
Fixed tests (14):
|
Codecov Report
@@ Coverage Diff @@
## main #2881 +/- ##
==========================================
- Coverage 51.24% 51.23% -0.02%
==========================================
Files 427 427
Lines 42522 42517 -5
==========================================
- Hits 21790 21783 -7
- Misses 20732 20734 +2
|
HalidOdat
requested review from
Razican,
jasonwilliams,
RageKnify,
raskad,
jedel1043 and
nekevss
April 29, 2023 21:38
HalidOdat
force-pushed
the
fix/regexp-constructor-is-regexp-check
branch
from
April 30, 2023 10:03
996f9ef
to
a11052f
Compare
Razican
approved these changes
Apr 30, 2023
raskad
approved these changes
Apr 30, 2023
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 30, 2023
Make the `RegExp` constructor call the `IsRegExp` function to check, not just internal slot check.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
[Merged by Bors] - Apr 30, 2023
RegExp
constructor should call IsRegExp()
RegExp
constructor should call IsRegExp()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
RegExp
constructor call theIsRegExp
function to check, not just internal slot check.