Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - RegExp constructor should call IsRegExp() #2881

Closed
wants to merge 2 commits into from

Conversation

HalidOdat
Copy link
Member

Make the RegExp constructor call the IsRegExp function to check, not just internal slot check.

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Apr 29, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Apr 29, 2023
@github-actions
Copy link

github-actions bot commented Apr 29, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,593 94,593 0
Passed 73,200 73,214 +14
Ignored 17,532 17,532 0
Failed 3,861 3,847 -14
Panics 0 0 0
Conformance 77.38% 77.40% +0.01%
Fixed tests (14):
test/annexB/built-ins/RegExp/prototype/Symbol.split/Symbol.match-getter-recompiles-source.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/Symbol.split/Symbol.match-getter-recompiles-source.js (previously Failed)
test/built-ins/RegExp/call_with_non_regexp_same_constructor.js [strict mode] (previously Failed)
test/built-ins/RegExp/call_with_non_regexp_same_constructor.js (previously Failed)
test/built-ins/RegExp/from-regexp-like-short-circuit.js [strict mode] (previously Failed)
test/built-ins/RegExp/from-regexp-like-short-circuit.js (previously Failed)
test/built-ins/RegExp/from-regexp-like-get-ctor-err.js [strict mode] (previously Failed)
test/built-ins/RegExp/from-regexp-like-get-ctor-err.js (previously Failed)
test/built-ins/RegExp/call_with_regexp_match_falsy.js [strict mode] (previously Failed)
test/built-ins/RegExp/call_with_regexp_match_falsy.js (previously Failed)
test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-called-once.js [strict mode] (previously Failed)
test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-called-once.js (previously Failed)
test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-this-throws.js [strict mode] (previously Failed)
test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-this-throws.js (previously Failed)

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #2881 (a11052f) into main (c738b50) will decrease coverage by 0.02%.
The diff coverage is 61.76%.

@@            Coverage Diff             @@
##             main    #2881      +/-   ##
==========================================
- Coverage   51.24%   51.23%   -0.02%     
==========================================
  Files         427      427              
  Lines       42522    42517       -5     
==========================================
- Hits        21790    21783       -7     
- Misses      20732    20734       +2     
Impacted Files Coverage Δ
boa_engine/src/builtins/string/mod.rs 57.81% <46.66%> (-0.21%) ⬇️
boa_engine/src/builtins/regexp/mod.rs 63.69% <73.68%> (-0.38%) ⬇️

@HalidOdat HalidOdat force-pushed the fix/regexp-constructor-is-regexp-check branch from 996f9ef to a11052f Compare April 30, 2023 10:03
@raskad
Copy link
Member

raskad commented Apr 30, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 30, 2023
Make the `RegExp` constructor call the `IsRegExp` function to check, not just internal slot check.
@bors
Copy link

bors bot commented Apr 30, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title RegExp constructor should call IsRegExp() [Merged by Bors] - RegExp constructor should call IsRegExp() Apr 30, 2023
@bors bors bot closed this Apr 30, 2023
@bors bors bot deleted the fix/regexp-constructor-is-regexp-check branch April 30, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants