Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divide the run() function #422

Merged
merged 52 commits into from
Jun 6, 2020
Merged

Divide the run() function #422

merged 52 commits into from
Jun 6, 2020

Conversation

Lan2u
Copy link

@Lan2u Lan2u commented May 26, 2020 •
edited
Loading

This Pull Request relates to #366.

The following AST nodes have been moved into their own files.

  • Break
  • ConditionalOp
  • Continue
  • DoWhileLoop
  • GetConstField
  • GetField
  • If
  • Object
  • Return
  • Switch
  • Spread
  • Throw
  • WhileLoop

@Lan2u Lan2u marked this pull request as draft May 26, 2020 17:14
Razican
Razican reviewed May 26, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing great progress! keep it coming! :D

boa/src/syntax/parser/expression/primary/object_initializer/mod.rs Outdated Show resolved Hide resolved
boa/src/syntax/ast/node/object.rs Outdated Show resolved Hide resolved
@Razican Razican added enhancement New feature or request technical debt labels May 26, 2020
@Razican Razican self-assigned this May 26, 2020
Paul Lancaster and others added 18 commits May 27, 2020 08:31
@Razican
Remove extra newline
744dee8 
Co-authored-by: Iban Eguia <razican@protonmail.ch>
Replaced AST object new with From
dc6b371
Merge branch 'divide_run' of https://github.com/Lan2u/boa into divide…
8995fb2 
…_run
Rustfmt
d91ac61
Merge pull request #5 from Lan2u/divide_run
274910a 
Catchup
Starting to move switch AST into seperate files
4b0bed1
Seperated switch AST node into seperate files
8ff5590
Merge: Seperated switch AST node into seperate files
d0e82b5 
Switch part divided up from run
Started moving GetConstField related parts into own file
6851036
Correcting various references to Node::GetConstField to use new signa…
153f0b1 
…ture
Extracted GetField code
c0404f3
Fmt, clippy
e33a1a5
Merge pull request #7 from Lan2u/divide_run_get_const_field
9969748 
Divided up GetConstField, GetField
WhileLoop
4937dc3 
seperated out
Impl fmt::display for WhileLoop
ad07527
DoWhileLoop struct created
be04070
Seperated out do while loop
58f83f7
Merge pull request #8 from Lan2u/divide_run_dowhile
26fdf9d 
Divide run dowhile
Paul Lancaster and others added 10 commits June 1, 2020 12:26
@Razican
Update boa/src/exec/throw/mod.rs
57cace0 
Co-authored-by: Iban Eguia <razican@protonmail.ch>
@Razican
Update boa/src/syntax/ast/node/break_node.rs
e96f79c 
Co-authored-by: Iban Eguia <razican@protonmail.ch>
@Razican
Update boa/src/syntax/ast/node/conditional.rs
44da6aa 
Co-authored-by: Iban Eguia <razican@protonmail.ch>
@Razican
Update boa/src/syntax/ast/node/iteration.rs
43a046f 
Co-authored-by: Iban Eguia <razican@protonmail.ch>
Made Switch::new() more generic, added TODO for break in Switch::run()
7604c0f
Merge branch 'divide_run' of https://github.com/Lan2u/boa into divide…
ba5a63b 
…_run
Making parse functions return the actual result of the parse rather t…
b7a641b 
…han a Node where possible
Reworked switch::new, added Case struct
ea45b26
Switch::run() refractored, rustfmt
7733da2
Merge branch 'master' into divide_run
cf75799
@codecov
Copy link

codecov bot commented Jun 1, 2020 •
edited
Loading

Codecov Report

Merging #422 into master will decrease coverage by 0.24%.
The diff coverage is 53.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   66.09%   65.84%   -0.25%     
==========================================
  Files         128      143      +15     
  Lines        8992     9133     +141     
==========================================
+ Hits         5943     6014      +71     
- Misses       3049     3119      +70
Impacted Files Coverage Δ
boa/src/exec/switch/mod.rs 0.00% <0.00%> (ø)
boa/src/syntax/ast/node/mod.rs 17.94% <0.00%> (-6.42%) ⬇️
boa/src/syntax/ast/node/statement_list.rs 18.75% <0.00%> (+2.96%) ⬆️
boa/src/syntax/ast/node/switch.rs 0.00% <0.00%> (ø)
...syntax/parser/expression/assignment/conditional.rs 55.00% <0.00%> (ø)
boa/src/syntax/parser/statement/switch/mod.rs 0.00% <0.00%> (ø)
boa/src/syntax/ast/node/conditional.rs 25.00% <25.00%> (ø)
boa/src/syntax/ast/node/object.rs 25.00% <25.00%> (ø)
boa/src/syntax/ast/node/break_node.rs 33.33% <33.33%> (ø)
...rc/syntax/parser/expression/left_hand_side/call.rs 42.50% <33.33%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b0741...e50a741. Read the comment docs.

@Lan2u Lan2u mentioned this pull request Jun 1, 2020
Merged
Paul Lancaster and others added 4 commits June 2, 2020 00:40
@Razican
Update boa/src/syntax/ast/node/return_smt.rs
b73182e 
Co-authored-by: Iban Eguia <razican@protonmail.ch>
@Razican
Update boa/src/syntax/ast/node/switch.rs
e95b6e4 
Co-authored-by: Iban Eguia <razican@protonmail.ch>
@Razican
Update boa/src/syntax/ast/node/return_smt.rs
e6072c8 
Co-authored-by: Iban Eguia <razican@protonmail.ch>
Small fixes to return_smt
ad91f42
@Lan2u Lan2u mentioned this pull request Jun 2, 2020
Closed
@Lan2u Lan2u requested a review from Razican June 3, 2020 09:08
@Lan2u Lan2u mentioned this pull request Jun 3, 2020
Merged
@jasonwilliams
Copy link
Member

You have quite a few conflicts. @Lan2u

@Lan2u
Copy link
Author

Lan2u commented Jun 5, 2020

You have quite a few conflicts. @Lan2u

It appears these were all related to the addition of the BoaProfiler to the master branch today, I have gone through and fixed all the conflicts :)

Razican
Razican approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@HalidOdat HalidOdat merged commit 84574b5 into boa-dev:master Jun 6, 2020
@Lan2u Lan2u deleted the divide_run branch June 6, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees

@Razican Razican

Labels
enhancement New feature or request technical debt
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Lan2u @jasonwilliams @Razican @HalidOdat