Switch impl #451
Merged
Switch impl #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Iban Eguia <razican@protonmail.ch>
Switch part divided up from run
Divided up GetConstField, GetField
Divide run dowhile
Razican
added
enhancement
This was
linked to
issues
Jun 6, 2020
Razican
reviewed
Jun 8, 2020
boa/src/exec/break_node/mod.rs
Outdated
|
|
||
| impl Executable for Break { | ||
| fn run(&self, interpreter: &mut Interpreter) -> ResultValue { | ||
| interpreter.is_break = true; |
There was a problem hiding this comment.
Here, we could have a break(label: &str) function (signature might differ) in interpreter, which would change the state.
Razican
reviewed
Jun 10, 2020
Done, I also got rid of the .is_return() etc. in favour of just matching on get_current_state() based on the assumption that almost all the time in the code if .is_return() needs to be handled then so does .is_break() so might as-well make this required to prevent accidental omissions. I haven't attempted to actually add any handling of break labels https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/label (this might be better as a separate issue?) |
Razican
approved these changes
Jun 11, 2020
jasonwilliams
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request implements #439 and #301.
It changes the following:
A function parse_generalised in statement list was created as part of this and is a more generalised version of StatementList::parse() which allows statement lists to be terminated by tokens other than '}'. It's a separate function for now so that the performance impact of replacing parse can be established.
This pull request is based of PR #422.