-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Vector::ptr_eq confusions #131
Comments
cmyr
added a commit
to cmyr/im-rs
that referenced
this issue
May 13, 2020
I believe the intent of this code was to consider the last two operations as a single OR. (I may be wrong) - closes bodil#131
Ok, I have a maybe-solution up at #132? 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Trying to understand what behaviour I should expect from
Vector::ptr_eq
.In particular, I am surprised that the following test passes:
That is: with 64 elements the ptr_eq returns
false
after mutation, and with 65 elements (and any more than that, as far as I've tested) it returnstrue
.I assume this is just a bug, but nothing has jumped out at me. I'll look at this a bit more, but curious for any guidance.
The text was updated successfully, but these errors were encountered: