Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic error in Vector::ptr_eq #132

Merged
merged 1 commit into from
May 15, 2020
Merged

Fix logic error in Vector::ptr_eq #132

merged 1 commit into from
May 15, 2020

Conversation

cmyr
Copy link
Contributor

@cmyr cmyr commented May 13, 2020

I believe the intent of this code was to consider the last two
operations as a single OR. (I may be wrong)

@cmyr cmyr mentioned this pull request May 13, 2020
Closed
@xStrom
Copy link

xStrom commented May 13, 2020

This same issue seems to exist in the PartialEq implementation where it was likely copy-pasted from.

@cmyr
Copy link
Contributor Author

cmyr commented May 13, 2020

noted, thanks, updated this.

@cmyr
Fix logic error in Vector::ptr_eq & PartialEq
8321f11 
~I believe the intent of this code was to consider the last two
operations as a single OR. (I may be wrong)~

update: It looks like this is a bug, introduced into the PartialEq
impl in 6d0b068, and then copied over when ptr_eq was added.

- closes bodil#131
@bodil
Copy link
Owner

bodil commented May 15, 2020

That's a bug all right, thanks for the fix!

@bodil bodil merged commit f744912 into bodil:master May 15, 2020
@bodil bodil mentioned this pull request May 15, 2020
Closed
@cmyr cmyr deleted the issue-131 branch May 15, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional Vector::ptr_eq confusions
3 participants
@cmyr @xStrom @bodil