Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the auth token for GCS backend #384

Closed
agoston opened this issue Oct 1, 2021 · 0 comments · Fixed by #435
Closed

Cache the auth token for GCS backend #384

agoston opened this issue Oct 1, 2021 · 0 comments · Fixed by #435
Labels
unftp-sbe-gcs Everything to do with the Google bucket backend.

Comments

@agoston
Copy link
Contributor

agoston commented Oct 1, 2021

ATM we re-request the auth token before each GCS REST query.

We need to use the built-in oauth refresh mechanism for ServiceAccounts, while for Workload Identity, we probably need a caching of the token.

CloudStorage is cloned per-connection, so it seems to be quite straightforward.
@hannesdejager hannesdejager added the unftp-sbe-gcs Everything to do with the Google bucket backend. label Jun 20, 2022
@wgfm wgfm mentioned this issue Oct 14, 2022
Merged
hannesdejager pushed a commit that referenced this issue Oct 14, 2022
Cache access token in unftp-sbe-gcs (#435)
772d6b7 
This commit implements caching for access tokens in the Google Cloud Storage backend. Before this we re-requested the auth token before each GCS REST query.

I'm using an RwLock rather than a Mutex, since the token is read much more often than it's written.

I also changed the name of the workflow_identity module to workload_identity.

Resolves #384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unftp-sbe-gcs Everything to do with the Google bucket backend.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache access token in unftp-sbe-gcs bolcom/libunftp
2 participants
@hannesdejager @agoston