Cache access token in unftp-sbe-gcs #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2022 09:52
|
Very nice contribution thanks. It looks good to me although we need to think how to test this. @robklg any suggestions? |
|
I just extracted the token cache into its own type, and tested that. It doesn't cover the changes I made in CloudStorage, but I'm confident that the caching logic works now. |
fbs
reviewed
Oct 14, 2022
We'll make an RC / Edge release and test it in the environment. If you're happy with this I'd like to merge it |
|
I'm happy when you are. Feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements caching for access tokens in the Google Cloud Storage backend.
I'm using an RwLock rather than a Mutex, since the token is read much more often than it's written.
If !433 is accepted, I will change the approach of this PR, since that will make it easier to pull the caching logic out of the CloudStorage struct, and into its own type.
I also changed the name of the
workflow_identitymodule toworkload_identity.I still need to figure out how to properly test this. Any suggestions are welcome.
Resolves #384