Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for BYE command #453

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Adding support for BYE command #453

merged 1 commit into from
Mar 19, 2023

Conversation

Phosphorus15
Copy link
Contributor

@Phosphorus15 Phosphorus15 commented Mar 14, 2023 •
edited
Loading

Should support this command as an alias of QUIT, some clients would use this command https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/ftp-bye

hannesdejager
hannesdejager approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@hannesdejager hannesdejager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannesdejager
Copy link
Collaborator

@Phosphorus15 can you run cargo fmt and push again? thanks

@Phosphorus15
Copy link
Contributor Author

@Phosphorus15 can you run cargo fmt and push again? thanks

Done!

@robklg robklg merged commit ef8a27b into bolcom:master Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannesdejager hannesdejager hannesdejager approved these changes

@robklg robklg robklg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phosphorus15 @hannesdejager @robklg