Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 #19

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Add Python 3.10 #19

merged 2 commits into from
Nov 26, 2021

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 6, 2021

Fixes #15.

Python 3.10 was released on 2021-10-04:

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #19 (936933f) into master (5d0ae28) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          343       343           
  Branches        52        52           
=========================================
  Hits           343       343           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0ae28...936933f. Read the comment docs.

Copy link
Owner

@bolsote bolsote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, and apologies for my rather long delay in reviewing. I was unavailable for quite some time.

The changes look good. Semgrep seems to be as temperamental as usual, but I'll deal with that separately. Only one nitpick: would it be possible to also include a 3.10 environment in tox.ini?

@hugovk
Copy link
Contributor Author

hugovk commented Nov 26, 2021

No need to apologise :)

There's already py310 in tox.ini's envlist, is something else needed?

@bolsote
Copy link
Owner

bolsote commented Nov 26, 2021

Oh, completely missed a whole file for review, somehow. Everything is absolutely fine, I'll just approve and merge now. Thank you very much for the contribution.

As an aside, I'm aware of what's going on in gweis/isodate#65 and I'd like to have a chat about it. My email should be in my profile, so feel free to ping me any time.

@bolsote bolsote merged commit ae0bd61 into bolsote:master Nov 26, 2021
@hugovk hugovk deleted the patch-1 branch November 27, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Officially support Python 3.10
2 participants