Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ERB for windows #203

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Fix ERB for windows #203

merged 1 commit into from
Feb 16, 2022

Conversation

tongueroo
Copy link
Contributor

@tongueroo tongueroo commented Feb 16, 2022 •
edited
Loading

This is a 🐞 bug fix.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Fix binary / text file detection for windows. Assume text file.

Note: Looking more closely at TextFile. It has a few other issues. Will fix in another PR.

Context

#202

How to Test

Go through one of the getting started guides on Windows machine.

Version Changes

patch

@tongueroo tongueroo merged commit 9b464e0 into master Feb 16, 2022
@tongueroo tongueroo deleted the windows branch February 16, 2022 22:50
@tongueroo tongueroo mentioned this pull request Feb 16, 2022
Merged
3 tasks
@tongueroo tongueroo changed the title Update text_file.rb Fix ERB for windows Feb 16, 2022
@tongueroo tongueroo mentioned this pull request Feb 17, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tongueroo