feat: fix and update autosuggest #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRuby
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Hey @timrbula - nice changes here, it was looking good to me and confirmed in flow
LucasGrimauth
approved these changes
Jan 26, 2023
Okisa
requested changes
Jan 26, 2023
hey @isakawa-carbon I need to publish a new beta version w/ the latest changes I made and update Flow. I'll do that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
The AutoSuggest component doesn't work
Context
Version Number: 4.0.2-beta.0
Checklist
PR Review Guidance
I tested locally in Storybook and with Flow in boomerang-io/flow.client.web#174
Additional Info
Just need to make sure that you can make multiple selections and the cursor stays in the correct position, you can cycle through options, etc