Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 156 vite + carbon 11 migration #174

Merged
merged 43 commits into from
Jan 27, 2023
Merged

Feat 156 vite + carbon 11 migration #174

merged 43 commits into from
Jan 27, 2023

Conversation

timrbula
Copy link
Member

@timrbula timrbula commented Jan 18, 2023 •
edited
Loading

Context

Related Issues(s): #156

Build Number: 3.12.12

Checklist:

  • Verified in an integrated environment
  • Unit and integration tests passing
  • Semantic HTML with accessibility support
  • No linting, test console, or browser console errors (best effort)
  • JSDoc comment blocks for complex code

PR Review Guidance

Well, check that everything works :|

  • Unit and integration tests are passing

Additional Info

It's a big one

  • Vite
  • Carbon 11
  • Latest addons lib

TODO

  • Cleanup

timrbula and others added 30 commits July 29, 2022 16:38
@timrbula
feat: vite migration wip
e2388d5
@timrbula
feat: vite migration wip
5f5d83a
@timrbula
feat: vitest wip
d3c4bad
@timrbula
feat: cypress v10 wip
d9df592
@timrbula
test: vitest
8fc5c4c
@timrbula
Feat: update a lot of snapshots
2147e78
@timrbula
fix: a bunch of snapshots
5d58d95
@timrbula
feat: wip, getting there
f023fbf
@timrbula
chore: delete old snapshots
335482b
@timrbula
feat: continue migration
f38dcba
@timrbula
Feat: migrate teams
a003b92
@timrbula
feat: migrate users
ea2a620
@timrbula
feat: continue migration
c62336c
@timrbula
feat: update some things
ee4771c
@isakawa-carbon
fix: react markdown
13969e3
@isakawa-carbon
fix: couple of combo box and composed modals
522b51a
@isakawa-carbon
fix: tabs, properties toggle and other fixes
2733478
@isakawa-carbon
fix: quota numver input and settings style
6aaa482
@isakawa-carbon
test: update tests
b4a60cb
@timrbula
test: update unit tests
a2cd322
@isakawa-carbon
Merge branch 'feat-156-vite-migration' of https://github.com/boomeran…
d5d87b0 
…g-io/flow.client.web into feat-156-vite-migration
@isakawa-carbon
fix: slider input
abc67ab
@timrbula
fix: remove testing
3a4667f
@timrbula
fix: remove duplicate attr
ca1fc86
@timrbula
feat: use node 16 for actions
5c92782
@timrbula
feat: use latest
fe21904
@timrbula
feat: use latest again
7cc72c9
@timrbula
feat: try again
474c292
@timrbula
test: comment out failing tests
41baa09
@timrbula
feat: bump packages, fix prod issue
f13c95f
@timrbula timrbula requested a review from Okisa January 18, 2023 23:07
@timrbula timrbula changed the title Feat 156 vite migration Feat 156 vite + carbon 11 migration Jan 18, 2023
LucasGrimauth
LucasGrimauth reviewed Jan 19, 2023
View reviewed changes
Copy link
Member

@LucasGrimauth LucasGrimauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tim, almost everything looks good! Some nitpicks I noticed:

  1. The Execution "View Log" modal has its toggle clipped a bit.

image

  1. The text and icons on these buttons seem to be too close.

image

Okisa
Okisa requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@Okisa Okisa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tim! Looking good!
The only issue I saw is the drag and drop not working on the Task Manager / Team Tasks on Definition Fields.

@timrbula
Copy link
Member Author

Hey Tim! Looking good! The only issue I saw is the drag and drop not working on the Task Manager / Team Tasks on Definition Fields.

Thanks, fixed

@timrbula timrbula marked this pull request as ready for review January 23, 2023 16:10
Okisa
Okisa previously approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@Okisa Okisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now!

@LucasGrimauth LucasGrimauth self-requested a review January 24, 2023 11:44
LucasGrimauth
LucasGrimauth reviewed Jan 24, 2023
View reviewed changes
Copy link
Member

@LucasGrimauth LucasGrimauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Tim! Only thing I noticed now is that the "Follow log" toggle I mentioned before doesn't seem to be working. It doesn't change its state when I click on it.

@Okisa Okisa self-requested a review January 24, 2023 22:20
Okisa
Okisa previously approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@Okisa Okisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev, all good!

@timrbula timrbula mentioned this pull request Jan 25, 2023
Merged
4 tasks
@LucasGrimauth LucasGrimauth self-requested a review January 26, 2023 14:02
LucasGrimauth
LucasGrimauth approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@LucasGrimauth LucasGrimauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Tim!

@timrbula timrbula merged commit 8df8641 into main Jan 27, 2023
@timrbula timrbula deleted the feat-156-vite-migration branch January 27, 2023 16:38
@timrbula timrbula mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasGrimauth LucasGrimauth LucasGrimauth approved these changes

@Okisa Okisa Okisa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timrbula @Okisa @LucasGrimauth @isakawa-carbon