Hessian corner detector #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simmplecoder
added
the
status/work-in-progress
simmplecoder
added
cat/feature
|
@simmplecoder I know close to nothing about Hessian detector. I can only offer a nitpicking C++ guidelines/style review. Do you still wish to have one? |
|
@mloskot , yes, any constructive criticism is welcome! (Boost guidelines, GIL guidelines, any other concerns). |
mloskot
requested changes
Aug 10, 2019
mloskot
approved these changes
Aug 18, 2019
stefanseefeld
approved these changes
Aug 20, 2019
This commit partially implements Hessian corner detector, but only uses determinant as Hessian response
This commit complements last one by summing in a window and applying det - k * trace * trace formula to final Hessian response
This commit adds docs to new functions, and makes function and variable names align with docs to not confuse readers
A-KAZE uses only determinant in it's response, and since for now Hessian is only a mean to advance A-KAZE implementation, response function is adjusted to use only determinant
This commit adds an s at the end of function name to make it uniform with another detector, and adds a simple test for sanity check
dx and similar naming seems to be confusing, improved documentation to explain the naming convention
Mostly changes to constness and integral types, with small cosmetic changes mixed in
Fixes typo in call for Hessian and addresses a review comment about replacing multiple exact indexing calls to one with a reference
Add literature reference to luminosity computation, and perform some cosmetic changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit implements Hessian corner detector, with response function being the same as in Harris.
Compatibility
Anything compatible with Boost 1.70
References
https://en.wikipedia.org/wiki/Hessian_matrix
Tasklist
Add larger docs to explain the algorithm betterwill be covered by another PR